Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Issue 7633061: Merge 94892 - Pepper quota support (Closed)

Created:
9 years, 4 months ago by kinuko
Modified:
9 years, 4 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Merge 94892 - Pepper quota support Probably this could be better implemented using push notification model, but in this patch I made this very straightforwardly (with possibly minimal change). * Added QuotaFileIO class (in quota_file_io.{cc,h}) which performs pre- and post- write quota related operations. * For Write/SetLength the QuotaFileIO instance first performs QueryFileInfo and QueryAvailableSpace to get the file size and current available space. If the results look good it dispatches actual Write/SetLength operations. After the operation has succeeded it then notifies the browser that it has made a storage modify operation. * For WillWrite/WillSetLength this change assumes they are always followed by actual write/setlength operations and the operations will succeed. Based on another cleanup patch: http://codereview.chromium.org/7438001/ BUG=86556 TEST=QuotaFileIOTest.* Review URL: http://codereview.chromium.org/7433006 TBR=kinuko@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -16 lines) Patch
M content/browser/file_system/file_system_dispatcher_host.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/file_system/file_system_dispatcher_host.cc View 3 chunks +28 lines, -0 lines 0 comments Download
M content/common/file_system_messages.h View 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 3 chunks +34 lines, -0 lines 0 comments Download
M ppapi/tests/test_file_io.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/test_file_io.cc View 3 chunks +88 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 2 chunks +9 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_unittest.h View 2 chunks +4 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppapi_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_file_io_impl.h View 5 chunks +11 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_io_impl.cc View 9 chunks +81 lines, -15 lines 0 comments Download
A + webkit/plugins/ppapi/quota_file_io.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/plugins/ppapi/quota_file_io.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/plugins/ppapi/quota_file_io_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kinuko
9 years, 4 months ago (2011-08-15 14:16:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698