src/flag-definitions.h - Issue 763273002: Introduce a kill-switch for shipping features.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/flag-definitions.h

Issue 763273002: Introduce a kill-switch for shipping features. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix test that was failing under nosnap Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/flag-definitions.h

diff --git a/src/flag-definitions.h b/src/flag-definitions.h

index 1460315dbb60189a6e0ffbb785d8d0a001e79998..d1e74b640c44437bafb1f6ba04483decdfdb7e9c 100644

--- a/src/flag-definitions.h

+++ b/src/flag-definitions.h

@@ -157,6 +157,7 @@ DEFINE_BOOL(use_strict, false, "enforce strict mode")

DEFINE_BOOL(es_staging, false, "enable all completed harmony features")

DEFINE_BOOL(harmony, false, "enable all completed harmony features")

+DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony fetaures")

DEFINE_IMPLICATION(harmony, es_staging)

DEFINE_IMPLICATION(es_staging, harmony)

@@ -200,8 +201,9 @@ HARMONY_INPROGRESS(FLAG_INPROGRESS_FEATURES)

HARMONY_STAGED(FLAG_STAGED_FEATURES)

#undef FLAG_STAGED_FEATURES

-#define FLAG_SHIPPING_FEATURES(id, description) \

- DEFINE_BOOL_READONLY(id, true, "enable " #description)

+#define FLAG_SHIPPING_FEATURES(id, description) \

+ DEFINE_BOOL(id, false, "enable " #description) \

+ DEFINE_IMPLICATION(harmony_shipping, id)

HARMONY_SHIPPING(FLAG_SHIPPING_FEATURES)

#undef FLAG_SHIPPING_FEATURES

« no previous file with comments | « src/bootstrapper.cc ('k') | src/mksnapshot.cc » ('j') | no next file with comments »