Introduce a kill-switch for shipping features.

src/flag-definitions.h

Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index d17f64facba134f1bc03770c5f97c7aecc8f7124..16e9171eb9ce4aff6cc378b649d42ad1570d8ec8 100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -157,6 +157,7 @@ DEFINE_BOOL(use_strict, false, "enforce strict mode")
 
 DEFINE_BOOL(es_staging, false, "enable all completed harmony features")
 DEFINE_BOOL(harmony, false, "enable all completed harmony features")
+DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony fetaures")
 DEFINE_IMPLICATION(harmony, es_staging)
 DEFINE_IMPLICATION(es_staging, harmony)
 
@@ -200,8 +201,9 @@ HARMONY_INPROGRESS(FLAG_INPROGRESS_FEATURES)
 HARMONY_STAGED(FLAG_STAGED_FEATURES)
 #undef FLAG_STAGED_FEATURES
 
-#define FLAG_SHIPPING_FEATURES(id, description) \
-  DEFINE_BOOL_READONLY(id, true, "enable " #description)
+#define FLAG_SHIPPING_FEATURES(id, description)  \
+  DEFINE_BOOL(id, false, "enable " #description) \
+  DEFINE_IMPLICATION(harmony_shipping, id)

[rossberg, 2014/11/28 12:28:36]

Hm, don't you also need a NEG_IMPLICATION here to actually make
--noharmony-shipping a kill switch?

[Dmitry Lomov (no reviews), 2014/11/28 13:34:41]

No, why? NEG_IMPLICATION(flag1,flag2) means `if (flag1) flag2 = false` so not
applicable here.

The way this works here is that features are off by default, and
harmony_shipping turns them on.
harmony_shipping is on by default, so features are on.
If harmony_shipping is turned off via command line, feature flags take their
default value which is 'off'.

[rossberg, 2014/11/28 13:41:02]

Ah, I see.

 HARMONY_SHIPPING(FLAG_SHIPPING_FEATURES)
 #undef FLAG_SHIPPING_FEATURES