Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java

Issue 763253005: [Android] Add AppMenu touch duration metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/appmenu/app_menu_drag_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java
index 6f79b8551ae6bad6a4c0fb132808b7952f2c0738..99d34c3e6ba3aa38bdb427c960285d42d12613b2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java
@@ -146,6 +146,7 @@ class AppMenuDragHelper {
final int roundedRawX = Math.round(rawX);
final int roundedRawY = Math.round(rawY);
final int eventActionMasked = event.getActionMasked();
+ final long timeSinceDown = event.getEventTime() - event.getDownTime();
final ListView listView = mAppMenu.getPopup().getListView();
mLastTouchX = rawX;
@@ -154,9 +155,11 @@ class AppMenuDragHelper {
if (eventActionMasked == MotionEvent.ACTION_CANCEL) {
mAppMenu.dismiss();
return true;
+ } else if (eventActionMasked == MotionEvent.ACTION_UP) {
+ nativeRecordAppMenuTouchDuration(timeSinceDown);
}
- mIsSingleTapCanceled |= event.getEventTime() - event.getDownTime() > mTapTimeout;
+ mIsSingleTapCanceled |= timeSinceDown > mTapTimeout;
mIsSingleTapCanceled |= !pointInView(button, event.getX(), event.getY(), mScaledTouchSlop);
if (!mIsSingleTapCanceled && eventActionMasked == MotionEvent.ACTION_UP) {
UmaBridge.usingMenu(false, false);
@@ -277,4 +280,6 @@ class AppMenuDragHelper {
mScreenVisibleRect.offset(mScreenVisiblePoint[0], mScreenVisiblePoint[1]);
return mScreenVisibleRect;
}
+
+ private static native void nativeRecordAppMenuTouchDuration(long timeMs);
}
« no previous file with comments | « no previous file | chrome/browser/android/appmenu/app_menu_drag_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698