chrome/browser/android/appmenu/app_menu_drag_helper.cc - Issue 763253005: [Android] Add AppMenu touch duration metric.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/appmenu/app_menu_drag_helper.cc

Issue 763253005: [Android] Add AppMenu touch duration metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java ('K') | « chrome/browser/android/appmenu/app_menu_drag_helper.h ('k') | chrome/browser/android/chrome_jni_registrar.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/metrics/histogram_macros.h"

	6 #include "chrome/browser/android/appmenu/app_menu_drag_helper.h"

	7 #include "jni/AppMenuDragHelper_jni.h"

	8

	9 namespace appmenu {
	Ted C 2014/12/10 17:28:55 These namespaces are way too specific. I think in These namespaces are way too specific. I think in the chrome package, they are promoting the removal of all namespaces, so I think you can just drop these (and maybe make the name RecordAppMenuTouchDuration for name collision prevention). Kibeom Kim (inactive) 2014/12/15 22:14:30 Done. Show quoted text On 2014/12/10 17:28:55, Ted C wrote: > These namespaces are way too specific. I think in the chrome package, they are > promoting the removal of all namespaces, so I think you can just drop these (and > maybe make the name RecordAppMenuTouchDuration for name collision prevention). Done.
	10 namespace android {

	11

	12 bool RegisterAppMenuDragHelper(JNIEnv* env) {

	13 return RegisterNativesImpl(env);

	14 }

	15

	16 void RecordTouchDuration(JNIEnv* env, jclass jcaller, jlong time_ms) {
	Ted C 2014/12/10 17:28:55 add "// static" above this. add "// static" above this. Kibeom Kim (inactive) 2014/12/15 22:14:30 Done. Show quoted text On 2014/12/10 17:28:55, Ted C wrote: > add "// static" above this. Done.
	17 UMA_HISTOGRAM_TIMES("AppMenu.TouchDuration",

	18 base::TimeDelta::FromMilliseconds(time_ms));

	19 }

	20

	21 } // namespace android

	22 } // namespace appmenu

OLD	NEW