Source/core/layout/line/LineBreaker.cpp - Issue 763173003: Convert RenderBlockFlow code to use FloatingObject references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/line/LineBreaker.cpp

Issue 763173003: Convert RenderBlockFlow code to use FloatingObject references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: more usage of const with floatingObject Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/line/LineBreaker.cpp

diff --git a/Source/core/layout/line/LineBreaker.cpp b/Source/core/layout/line/LineBreaker.cpp

index 228a5ea97f03b002c079f4ab6848f5d4fc2a197c..cab143d56833534a153a95166cac0f2816f2bbc1 100644

--- a/Source/core/layout/line/LineBreaker.cpp

+++ b/Source/core/layout/line/LineBreaker.cpp

@@ -39,7 +39,7 @@ void LineBreaker::skipLeadingWhitespace(InlineBidiResolver& resolver, LineInfo&

lineInfo.incrementRunsFromLeadingWhitespace();

}

} else if (object->isFloating()) {

- m_block->positionNewFloatOnLine(m_block->insertFloatingObject(*toLayoutBox(object)), lastFloatFromPreviousLine, lineInfo, width);

+ m_block->positionNewFloatOnLine(*(m_block->insertFloatingObject(*toLayoutBox(object))), lastFloatFromPreviousLine, lineInfo, width);

Julien - ping for review 2015/06/10 15:15:44 Ditto.

Sunil Ratnu 2015/06/11 05:49:43 Done.

}

resolver.position().increment(&resolver);

}

« Source/core/layout/LayoutBlockFlow.h ('K') | « Source/core/layout/line/BreakingContextInlineHeaders.h ('k') | Source/core/layout/line/LineWidth.h » ('j') | no next file with comments »