Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 763063004: Flush correctly in VTVideoDecodeAccelerator. (Closed)

Created:
6 years ago by sandersd (OOO until July 31)
Modified:
6 years ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Flush correctly in VTVideoDecodeAccelerator. Previously flushing was requested but not actually waited for, resulting in flushing completing before frames were actually decoded. BUG=133828 Committed: https://crrev.com/a6d54b69098f7b4da1606cdcc6f39156fbdbf9ac Cr-Commit-Position: refs/heads/master@{#306435}

Patch Set 1 #

Patch Set 2 : Flush discarded sessions. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M content/common/gpu/media/vt.sig View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator.cc View 1 2 chunks +5 lines, -3 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
sandersd (OOO until July 31)
6 years ago (2014-12-02 01:12:57 UTC) #2
DaleCurtis
https://codereview.chromium.org/763063004/diff/20001/content/common/gpu/media/vt_video_decode_accelerator.cc File content/common/gpu/media/vt_video_decode_accelerator.cc (right): https://codereview.chromium.org/763063004/diff/20001/content/common/gpu/media/vt_video_decode_accelerator.cc#newcode249 content/common/gpu/media/vt_video_decode_accelerator.cc:249: OSStatus status = VTDecompressionSessionWaitForAsynchronousFrames(session_); Does blocking the decoder thread ...
6 years ago (2014-12-02 18:28:01 UTC) #3
DaleCurtis
lgtm % that q
6 years ago (2014-12-02 18:28:10 UTC) #4
sandersd (OOO until July 31)
https://codereview.chromium.org/763063004/diff/20001/content/common/gpu/media/vt_video_decode_accelerator.cc File content/common/gpu/media/vt_video_decode_accelerator.cc (right): https://codereview.chromium.org/763063004/diff/20001/content/common/gpu/media/vt_video_decode_accelerator.cc#newcode249 content/common/gpu/media/vt_video_decode_accelerator.cc:249: OSStatus status = VTDecompressionSessionWaitForAsynchronousFrames(session_); On 2014/12/02 18:28:01, DaleCurtis wrote: ...
6 years ago (2014-12-02 18:30:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/763063004/20001
6 years ago (2014-12-02 18:32:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-02 19:37:43 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-02 19:38:30 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a6d54b69098f7b4da1606cdcc6f39156fbdbf9ac
Cr-Commit-Position: refs/heads/master@{#306435}

Powered by Google App Engine
This is Rietveld 408576698