Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 763043004: Remove some unused WebRange functions (Closed)

Created:
5 years, 7 months ago by philipj_slow
Modified:
5 years, 7 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Remove some unused WebRange functions These were introduced in 2009 but have become unused since: http://trac.webkit.org/changeset/50687 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M Source/core/dom/Range.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/WebRange.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M public/web/WebRange.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
5 years, 7 months ago (2014-11-28 13:17:55 UTC) #2
Mike West
Purely negative CLs are best CLs. :) LGTM.
5 years, 7 months ago (2014-11-28 15:10:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/763043004/1
5 years, 7 months ago (2014-11-28 17:35:19 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2014-11-28 17:37:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186191

Powered by Google App Engine
This is Rietveld 408576698