Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 763033002: X87: harmony-scoping: make assignment to 'const' a late error. (Closed)

Created:
6 years ago by chunyang.dai
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

X87: harmony-scoping: make assignment to 'const' a late error. port 6ac4de87a8b01500b066a3e401e921d2d84b42db original commit message: harmony-scoping: make assignment to 'const' a late error. Per TC39 Nov 2014 decision. This patch also changes behavior for "legacy const": assignments to sloppy const in strict mode is now also a type error. This fixes v8:2243 and also brings us in compliance with other engines re assignment to function names (see updated webkit test), but might have bigger implications. That change can easily be reverted by changing Variable::IsSignallingAssignmentToConst. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/x87/full-codegen-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Weiliang
lgtm
6 years ago (2014-11-27 04:03:43 UTC) #2
Dmitry Lomov (no reviews)
lgtm
6 years ago (2014-11-27 07:06:01 UTC) #3
Weiliang
6 years ago (2014-11-27 07:12:34 UTC) #4
On 2014/11/27 07:06:01, Dmitry Lomov (chromium) wrote:
> lgtm

Committed as f89acb647f94

Powered by Google App Engine
This is Rietveld 408576698