Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: Source/core/html/HTMLObjectElement.cpp

Issue 76303002: CSP: Check <param> element values against the document's CSP before loading. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Async. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLObjectElement.cpp
diff --git a/Source/core/html/HTMLObjectElement.cpp b/Source/core/html/HTMLObjectElement.cpp
index a7e34dfee0ec436fc23165b459013f212569105a..c2751ebf6bf50e2cbe22c5aa2434900cc588c65c 100644
--- a/Source/core/html/HTMLObjectElement.cpp
+++ b/Source/core/html/HTMLObjectElement.cpp
@@ -270,14 +270,18 @@ void HTMLObjectElement::updateWidgetInternal()
ASSERT(needsWidgetUpdate());
setNeedsWidgetUpdate(false);
// FIXME: This should ASSERT isFinishedParsingChildren() instead.
- if (!isFinishedParsingChildren())
+ if (!isFinishedParsingChildren()) {
+ dispatchErrorEvent();
return;
+ }
// FIXME: I'm not sure it's ever possible to get into updateWidget during a
// removal, but just in case we should avoid loading the frame to prevent
// security bugs.
- if (!SubframeLoadingDisabler::canLoadFrame(*this))
+ if (!SubframeLoadingDisabler::canLoadFrame(*this)) {
+ dispatchErrorEvent();
return;
+ }
String url = this->url();
String serviceType = m_serviceType;
@@ -288,8 +292,10 @@ void HTMLObjectElement::updateWidgetInternal()
parametersForPlugin(paramNames, paramValues, url, serviceType);
// Note: url is modified above by parametersForPlugin.
- if (!allowedToLoadFrameURL(url))
+ if (!allowedToLoadFrameURL(url)) {
+ dispatchErrorEvent();
return;
+ }
bool fallbackContent = hasFallbackContent();
renderEmbeddedObject()->setHasFallbackContent(fallbackContent);
@@ -299,9 +305,12 @@ void HTMLObjectElement::updateWidgetInternal()
if (!renderer()) // Do not load the plugin if beforeload removed this element or its renderer.
return;
- bool success = beforeLoadAllowedLoad && hasValidClassId() && requestObject(url, serviceType, paramNames, paramValues);
- if (!success && fallbackContent)
- renderFallbackContent();
+ if (!beforeLoadAllowedLoad || !hasValidClassId() || !requestObject(url, serviceType, paramNames, paramValues)) {
+ if (!url.isEmpty())
+ dispatchErrorEvent();
+ if (fallbackContent)
+ renderFallbackContent();
+ }
}
bool HTMLObjectElement::rendererIsNeeded(const RenderStyle& style)

Powered by Google App Engine
This is Rietveld 408576698