Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 763013002: Get rid of the remaining uses of GraphicsLayer. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Get rid of the remaining uses of GraphicsLayer. After this patch, GraphicsLayer is only used by GraphicsLayer-related classes and LinkHighlight. We should be able to just delete all of them in a followup patch. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/65840c35b2cfa16452f9acd0b9d5531b7c73b451

Patch Set 1 #

Patch Set 2 : fix diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -201 lines) Patch
M sky/engine/core/frame/FrameView.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/inspector/InspectorTraceEvents.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/inspector/InspectorTraceEvents.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/loader/EmptyClients.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/ChromeClient.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/platform/graphics/Canvas2DLayerBridge.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/gpu/DrawingBuffer.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/web/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/web/LinkHighlight.cpp View 1 1 chunk +1 line, -21 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 4 chunks +1 line, -29 lines 0 comments Download
D sky/engine/web/painting/ContinuousPainter.h View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/engine/web/painting/ContinuousPainter.cpp View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
6 years ago (2014-11-27 02:36:41 UTC) #2
abarth-chromium
lgtm
6 years ago (2014-11-27 02:49:22 UTC) #3
ojan
6 years ago (2014-11-27 02:51:48 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
65840c35b2cfa16452f9acd0b9d5531b7c73b451.

Powered by Google App Engine
This is Rietveld 408576698