Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 762993003: Remove GraphicsLayer family of classes. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove GraphicsLayer family of classes. Remove all the GraphicsLayer* classes. This includes LinkHighlight since that feature is built on the old compositing system. It's all dead code! R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ed4fb58fbd4dd9e633b81d8bb5f91a67d0b338ea

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2217 lines) Patch
M sky/engine/core/frame/Frame.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/inspector/InspectorTraceEvents.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/inspector/InspectorTraceEvents.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/ChromeClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +1 line, -1 line 0 comments Download
D sky/engine/platform/graphics/GraphicsLayer.h View 1 chunk +0 lines, -321 lines 0 comments Download
D sky/engine/platform/graphics/GraphicsLayer.cpp View 1 chunk +0 lines, -781 lines 0 comments Download
D sky/engine/platform/graphics/GraphicsLayerClient.h View 1 chunk +0 lines, -83 lines 0 comments Download
D sky/engine/platform/graphics/GraphicsLayerDebugInfo.h View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/engine/platform/graphics/GraphicsLayerDebugInfo.cpp View 1 chunk +0 lines, -99 lines 0 comments Download
D sky/engine/platform/graphics/GraphicsLayerFactory.h View 1 chunk +0 lines, -46 lines 0 comments Download
M sky/engine/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.cpp View 1 chunk +2 lines, -3 lines 1 comment Download
M sky/engine/public/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/public/platform/WebGraphicsLayerDebugInfo.h View 1 chunk +0 lines, -47 lines 0 comments Download
M sky/engine/public/platform/WebLayer.h View 2 chunks +0 lines, -3 lines 0 comments Download
D sky/engine/public/platform/WebLayerClient.h View 1 chunk +0 lines, -55 lines 0 comments Download
M sky/engine/web/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/web/GraphicsLayerFactoryChromium.h View 1 chunk +0 lines, -42 lines 0 comments Download
D sky/engine/web/GraphicsLayerFactoryChromium.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
D sky/engine/web/LinkHighlight.h View 1 chunk +0 lines, -101 lines 0 comments Download
D sky/engine/web/LinkHighlight.cpp View 1 chunk +0 lines, -320 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebViewImpl.h View 5 chunks +0 lines, -14 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 7 chunks +0 lines, -154 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ojan
https://codereview.chromium.org/762993003/diff/1/sky/engine/platform/scroll/ScrollableArea.cpp File sky/engine/platform/scroll/ScrollableArea.cpp (right): https://codereview.chromium.org/762993003/diff/1/sky/engine/platform/scroll/ScrollableArea.cpp#newcode40 sky/engine/platform/scroll/ScrollableArea.cpp:40: #include "sky/engine/public/platform/WebString.h" ScrollableArea was depending on this import from ...
6 years ago (2014-11-27 03:16:02 UTC) #2
abarth-chromium
lgtm
6 years ago (2014-11-27 03:22:31 UTC) #3
abarth-chromium
I never understood why link highlighting needed all this special code.
6 years ago (2014-11-27 03:22:52 UTC) #4
ojan
6 years ago (2014-11-27 04:21:07 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ed4fb58fbd4dd9e633b81d8bb5f91a67d0b338ea.

Powered by Google App Engine
This is Rietveld 408576698