Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: src/debug.cc

Issue 76293003: Fix debugger wrt concurrent recompilation flag. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2038 matching lines...) Expand 10 before | Expand all | Expand 10 after
2049 void VisitThread(Isolate* isolate, ThreadLocalTop* top) { 2049 void VisitThread(Isolate* isolate, ThreadLocalTop* top) {
2050 RedirectActivationsToRecompiledCodeOnThread(isolate, top); 2050 RedirectActivationsToRecompiledCodeOnThread(isolate, top);
2051 } 2051 }
2052 }; 2052 };
2053 2053
2054 2054
2055 void Debug::PrepareForBreakPoints() { 2055 void Debug::PrepareForBreakPoints() {
2056 // If preparing for the first break point make sure to deoptimize all 2056 // If preparing for the first break point make sure to deoptimize all
2057 // functions as debugging does not work with optimized code. 2057 // functions as debugging does not work with optimized code.
2058 if (!has_break_points_) { 2058 if (!has_break_points_) {
2059 if (FLAG_concurrent_recompilation) { 2059 if (isolate_->concurrent_recompilation_enabled()) {
2060 isolate_->optimizing_compiler_thread()->Flush(); 2060 isolate_->optimizing_compiler_thread()->Flush();
2061 } 2061 }
2062 2062
2063 Deoptimizer::DeoptimizeAll(isolate_); 2063 Deoptimizer::DeoptimizeAll(isolate_);
2064 2064
2065 Handle<Code> lazy_compile = 2065 Handle<Code> lazy_compile =
2066 Handle<Code>(isolate_->builtins()->builtin(Builtins::kLazyCompile)); 2066 Handle<Code>(isolate_->builtins()->builtin(Builtins::kLazyCompile));
2067 2067
2068 // There will be at least one break point when we are done. 2068 // There will be at least one break point when we are done.
2069 has_break_points_ = true; 2069 has_break_points_ = true;
(...skipping 1782 matching lines...) Expand 10 before | Expand all | Expand 10 after
3852 { 3852 {
3853 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_)); 3853 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_));
3854 isolate_->debugger()->CallMessageDispatchHandler(); 3854 isolate_->debugger()->CallMessageDispatchHandler();
3855 } 3855 }
3856 } 3856 }
3857 } 3857 }
3858 3858
3859 #endif // ENABLE_DEBUGGER_SUPPORT 3859 #endif // ENABLE_DEBUGGER_SUPPORT
3860 3860
3861 } } // namespace v8::internal 3861 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698