Issue 762823003: Rename all_the_rest.dart to all_the_rest_test.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 762823003: Rename all_the_rest.dart to all_the_rest_test.dart. (Closed)

Created:
6 years ago by Paul Berry

Modified:
6 years ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename all_the_rest.dart to all_the_rest_test.dart. So that it will be run by the buildbots. Also fix a bug which would have caused the test 'DirectoryBasedDartSdkTest.getSdkVersion' to fail when run by the buildbots. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42068

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -11156 lines)			Patch
M	pkg/analyzer/lib/src/generated/sdk_io.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
D	pkg/analyzer/test/generated/all_the_rest.dart	View	1 chunk	+0 lines, -11154 lines	0 comments	Download
A +	pkg/analyzer/test/generated/all_the_rest_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	pkg/analyzer/test/generated/engine_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/test_all.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

6 years ago (2014-12-02 16:29:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42068 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages