Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1864)

Unified Diff: dart/pkg/dart2js_incremental/lib/library_updater.dart

Issue 762793002: Disable super-aliases during incremental compilation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Renames registerAliasedSuperMember. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/pkg/compiler/lib/src/ssa/codegen.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/dart2js_incremental/lib/library_updater.dart
diff --git a/dart/pkg/dart2js_incremental/lib/library_updater.dart b/dart/pkg/dart2js_incremental/lib/library_updater.dart
index 559de9699ba19585ff1f054a19cc4a06fd3b2920..e95aa0f0faaa9ac78030551c8384a2e5e655e6c5 100644
--- a/dart/pkg/dart2js_incremental/lib/library_updater.dart
+++ b/dart/pkg/dart2js_incremental/lib/library_updater.dart
@@ -650,12 +650,6 @@ class LibraryUpdater extends JsFeatures {
jsAst.Node elementAccess = namer.elementAccess(element.enclosingClass);
statements.add(
js.statement('#.prototype.# = f', [elementAccess, name]));
-
- if (backend.isAliasedSuperMember(element)) {
- String superName = namer.getNameOfAliasedSuperMember(element);
- statements.add(
- js.statement('#.prototype.# = f', [elementAccess, superName]));
- }
} else {
jsAst.Node elementAccess = namer.elementAccess(element);
jsAst.Expression globalFunctionsAccess =
@@ -796,10 +790,6 @@ class RemovedFunctionUpdate extends RemovalUpdate
/// non-instance methods.
String name;
- /// Name of super-alias property to remove using JavaScript "delete". Null
- /// for methods that aren't "super aliased", and non-instance methods.
- String superName;
-
/// For instance methods, access to class object. Otherwise, access to the
/// method itself.
jsAst.Node elementAccess;
@@ -820,9 +810,6 @@ class RemovedFunctionUpdate extends RemovalUpdate
if (element.isInstanceMember) {
elementAccess = namer.elementAccess(element.enclosingClass);
name = namer.getNameOfMember(element);
- if (backend.isAliasedSuperMember(element)) {
- superName = namer.getNameOfAliasedSuperMember(element);
- }
} else {
elementAccess = namer.elementAccess(element);
}
@@ -846,11 +833,6 @@ class RemovedFunctionUpdate extends RemovalUpdate
}
updates.add(
js.statement('delete #.prototype.#', [elementAccess, name]));
-
- if (superName != null) {
- updates.add(
- js.statement('delete #.prototype.#', [elementAccess, superName]));
- }
} else {
updates.add(js.statement('delete #', [elementAccess]));
}
« no previous file with comments | « dart/pkg/compiler/lib/src/ssa/codegen.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698