Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: dart/pkg/compiler/lib/src/js_backend/backend.dart

Issue 762793002: Disable super-aliases during incremental compilation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Renames registerAliasedSuperMember. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/pkg/compiler/lib/src/ssa/codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/dart/pkg/compiler/lib/src/js_backend/backend.dart b/dart/pkg/compiler/lib/src/js_backend/backend.dart
index 75238e4afa7d0c13f0826c011d8b72b76aa08c14..2ab846f23117a64a65be91e57f4aceda8eaa1085 100644
--- a/dart/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/dart/pkg/compiler/lib/src/js_backend/backend.dart
@@ -557,8 +557,17 @@ class JavaScriptBackend extends Backend {
/**
* Record that [method] is called from a subclass via `super`.
*/
- void registerAliasedSuperMember(FunctionElement method) {
- aliasedSuperMembers.add(method);
+ bool maybeRegisterAliasedSuperMember(Element member, Selector selector) {
+ if (selector.isGetter || compiler.hasIncrementalSupport) {
+ // Invoking a super getter isn't supported, this would require changes to
+ // compact field descriptors in the emitter.
+ // We also turn off this optimization in incremental compilation, to
+ // avoid having to regenerate a method just because someone started
+ // calling it through super.
+ return false;
+ }
+ aliasedSuperMembers.add(member);
+ return true;
}
/**
« no previous file with comments | « no previous file | dart/pkg/compiler/lib/src/ssa/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698