Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: src/isolate.cc

Issue 762773002: Don't use ConsStringIterator to compute string hashes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.h ('k') | src/objects.h » ('j') | src/objects.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 09ca02854f12282e81d70327209e7c0f52f1c903..6f19075ac5b9e02eb1084891028b9238078396c9 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -1635,6 +1635,7 @@ Isolate::Isolate(bool enable_serializer)
thread_manager_(NULL),
has_installed_extensions_(false),
string_tracker_(NULL),
+ cons_string_hashing_buffer_(nullptr),
regexp_stack_(NULL),
date_cache_(NULL),
call_descriptor_data_(NULL),
@@ -1881,6 +1882,9 @@ Isolate::~Isolate() {
delete eternal_handles_;
eternal_handles_ = NULL;
+ delete[] cons_string_hashing_buffer_;
+ cons_string_hashing_buffer_ = nullptr;
+
delete string_stream_debug_object_cache_;
string_stream_debug_object_cache_ = NULL;
@@ -1996,6 +2000,7 @@ bool Isolate::Init(Deserializer* des) {
handle_scope_implementer_ = new HandleScopeImplementer(this);
stub_cache_ = new StubCache(this);
materialized_object_store_ = new MaterializedObjectStore(this);
+ cons_string_hashing_buffer_ = new uint16_t[String::kMaxHashCalcLength];
regexp_stack_ = new RegExpStack();
regexp_stack_->isolate_ = this;
date_cache_ = new DateCache();
« no previous file with comments | « src/isolate.h ('k') | src/objects.h » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698