Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 762743002: Disable ParserSync test for now, it takes waaaaay too long. (Closed)

Created:
6 years ago by Sven Panne
Modified:
6 years ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Disable ParserSync test for now, it takes waaaaay too long. Running this in x64.release mode on a powerful HP620 takes 4 seconds, this is at least 2 orders of magnitude too slow and leads to tons of false positives on our build bots due to timeouts. As it is, the cost-benefit ratio is far too low. The whole approach needs to be changed: Instead of trying to exhaust some search space in unit tests, this should be turned into a fuzzing test where only a small but random number of things are tested. The exhaustive approach can be done separately, but definitely not in the unit tests. BUG=v8:3707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M test/cctest/test-parsing.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Sven Panne
6 years ago (2014-11-26 07:32:42 UTC) #2
Benedikt Meurer
lgtm
6 years ago (2014-11-26 07:46:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/762743002/1
6 years ago (2014-11-26 07:47:41 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-26 08:15:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698