Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 762723003: Prefix CommandLine usage with base namespace (Part 8: components) (Closed)

Created:
6 years ago by kkristof
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prefix CommandLine usage with base namespace (Part 8: components) Prefix all CommandLine usage in the components/ directory's following subdirectories: autofill, cloud_devices, crash, data_reduction_proxy and dom_distiller with the base:: namespace. BUG=422426 Committed: https://crrev.com/c3348259183454d20a97f875ed70316776332d78 Cr-Commit-Position: refs/heads/master@{#306576}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -55 lines) Patch
M components/autofill/content/browser/content_autofill_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/content_autofill_driver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/wallet/wallet_service_url.cc View 1 4 chunks +8 lines, -4 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_service_url_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_external_delegate_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/form_structure.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/form_structure_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/common/password_generation_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cloud_devices/common/cloud_devices_urls.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M components/crash/app/breakpad_linux.cc View 1 4 chunks +6 lines, -4 lines 0 comments Download
M components/crash/app/breakpad_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/app/breakpad_win.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M components/crash/tools/crash_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc View 1 4 chunks +7 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M components/dom_distiller/standalone/content_extractor.cc View 1 2 3 4 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (6 generated)
kkristof
Please look at this.
6 years ago (2014-11-26 16:20:44 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-11-27 14:55:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/762723003/1
6 years ago (2014-11-28 12:49:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/27122)
6 years ago (2014-11-28 12:52:28 UTC) #7
kkristof
On 2014/11/28 12:52:28, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years ago (2014-11-28 15:46:17 UTC) #8
Cait (Slow)
lgtm
6 years ago (2014-12-01 16:08:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/762723003/20001
6 years ago (2014-12-02 07:36:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/93146)
6 years ago (2014-12-02 08:04:48 UTC) #13
kkristof
Hi, I have fixed the build issue in the win port and also rebased it.
6 years ago (2014-12-02 09:56:11 UTC) #14
bengr
components/data_reduction_proxy and components/dom_distiller lgtm with two nits. https://codereview.chromium.org/762723003/diff/40001/components/dom_distiller/standalone/content_extractor.cc File components/dom_distiller/standalone/content_extractor.cc (right): https://codereview.chromium.org/762723003/diff/40001/components/dom_distiller/standalone/content_extractor.cc#newcode372 components/dom_distiller/standalone/content_extractor.cc:372: *base::CommandLine::ForCurrentProcess(); Indent ...
6 years ago (2014-12-02 16:17:32 UTC) #15
kkristof
On 2014/12/02 16:17:32, bengr wrote: > components/data_reduction_proxy and components/dom_distiller lgtm with two nits. Okay, I ...
6 years ago (2014-12-02 17:06:59 UTC) #16
bengr
On 2014/12/02 17:06:59, kkristof wrote: > On 2014/12/02 16:17:32, bengr wrote: > > components/data_reduction_proxy and ...
6 years ago (2014-12-02 20:21:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/762723003/60001
6 years ago (2014-12-03 07:58:21 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-03 08:49:00 UTC) #20
commit-bot: I haz the power
6 years ago (2014-12-03 08:49:51 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c3348259183454d20a97f875ed70316776332d78
Cr-Commit-Position: refs/heads/master@{#306576}

Powered by Google App Engine
This is Rietveld 408576698