Issue 762703005: Fix test_sky commandline printing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 762703005: Fix test_sky commandline printing. (Closed)

Created:
6 years ago by ojan

Modified:
6 years ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Fix test_sky commandline printing. 1. Print out the sky_server commandline as well so it's easy to run the server without running test_sky. 2. Quote the --args-for arguments, so that they copy-paste correctly. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c86b07f409c4698eccf5042ee1985f13971aaabb

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	sky/tools/webkitpy/layout_tests/port/base.py	View		2 chunks	+10 lines, -8 lines	0 comments	Download
	M	sky/tools/webkitpy/layout_tests/views/printing.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

ojan

6 years ago (2014-11-27 00:24:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c86b07f409c4698eccf5042ee1985f13971aaabb (presubmit successful).