Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 762703005: Fix test_sky commandline printing. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Fix test_sky commandline printing. 1. Print out the sky_server commandline as well so it's easy to run the server without running test_sky. 2. Quote the --args-for arguments, so that they copy-paste correctly. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c86b07f409c4698eccf5042ee1985f13971aaabb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M sky/tools/webkitpy/layout_tests/port/base.py View 2 chunks +10 lines, -8 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/views/printing.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ojan
6 years ago (2014-11-27 00:23:55 UTC) #2
abarth-chromium
lgtm
6 years ago (2014-11-27 00:23:58 UTC) #4
ojan
6 years ago (2014-11-27 00:24:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c86b07f409c4698eccf5042ee1985f13971aaabb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698