Add support for iOS WatchKit apps in GYP

Add support for iOS WatchKit apps in GYP

Adds new target types for Apple Watch apps and their corresponding
WatchKit extensions, along with a test and sample application.

Patch by David Patierno <dmpatierno@google.com>;

R=justincohen@chromium.org, sdefresne@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=2014

[dmpatierno, 2014-11-26 19:54:31]

dmpatierno@google.com changed reviewers:
+ justincohen@chromium.org

[justincohen, 2014-11-26 20:12:04]

I haven't looked at WatchKit yet so I'm not sure how building for device works. 
Is there no building for the equivalent to iphoneos?

Mostly a bunch of nits, but generally everything looks great!  Thanks!

https://codereview.chromium.org/762673002/diff/20001/pylib/gyp/generator/xcod...
File pylib/gyp/generator/xcode.py (right):

https://codereview.chromium.org/762673002/diff/20001/pylib/gyp/generator/xcod...
pylib/gyp/generator/xcode.py:73: 'ios_watch_app',
sort

https://codereview.chromium.org/762673002/diff/20001/pylib/gyp/xcodeproj_file.py
File pylib/gyp/xcodeproj_file.py (right):

https://codereview.chromium.org/762673002/diff/20001/pylib/gyp/xcodeproj_file...
pylib/gyp/xcodeproj_file.py:2243: 'com.apple.product-type.application':
['wrapper.application', '', '.app'],
this seems harder to read.

https://codereview.chromium.org/762673002/diff/20001/test/ios/gyptest-watch.py
File test/ios/gyptest-watch.py (right):

https://codereview.chromium.org/762673002/diff/20001/test/ios/gyptest-watch.p...
test/ios/gyptest-watch.py:15: if sys.platform == 'darwin' and
TestMac.Xcode.Version()>="0620":
nit space >=

https://codereview.chromium.org/762673002/diff/20001/test/ios/gyptest-watch.p...
test/ios/gyptest-watch.py:16: test = TestGyp.TestGyp(formats=['xcode'])
Does this not work on ninja too?

https://codereview.chromium.org/762673002/diff/20001/test/ios/gyptest-watch.p...
test/ios/gyptest-watch.py:22: test.set_configuration('Default-iphonesimulator')
Just simulator?

https://codereview.chromium.org/762673002/diff/20001/test/ios/watch/WatchKitE...
File test/ios/watch/WatchKitExtension/InterfaceController.m (right):

https://codereview.chromium.org/762673002/diff/20001/test/ios/watch/WatchKitE...
test/ios/watch/WatchKitExtension/InterfaceController.m:11: NSLog(@"%@
initWithContext", self);
nit nslogs...

[dmpatierno, 2014-12-01 19:59:53]

Thanks for the fast review! :)

> I haven't looked at WatchKit yet so I'm not sure how building for device
works. 
> Is there no building for the equivalent to iphoneos?

To be embedded in the app, the extension needs to be signed. Signing for devices
requires an Apple developer certificate, so for running the tests, using the
simulator looks like the only way.

> pylib/gyp/generator/xcode.py:73: 'ios_watch_app',
> sort

Done.
 
> pylib/gyp/xcodeproj_file.py:2243: 'com.apple.product-type.application':
> ['wrapper.application', '', '.app'],
> this seems harder to read.

Agreed. How’s this? Any other suggestions?
 
> test/ios/gyptest-watch.py:15: if sys.platform == 'darwin' and
> TestMac.Xcode.Version()>="0620":
> nit space >=

Done.

> test/ios/gyptest-watch.py:16: test = TestGyp.TestGyp(formats=['xcode'])
> Does this not work on ninja too?

It does not work on ninja. I also don't really know what ninja *is*. Some
alternative to Xcode's compiler?. If so, it will probably need to be updated to
catch up with Xcode 6.2. Here’s the error I see running the test with ninja:

ninja: error: 'WatchApp.app', needed by 'WatchKitExtension.appex/WatchApp.app',
missing and no known rule to make it

> test/ios/gyptest-watch.py:22:
test.set_configuration('Default-iphonesimulator')
> Just simulator?

There are signing issues with building for device. See top comment.

> test/ios/watch/WatchKitExtension/InterfaceController.m:11: NSLog(@"%@
> initWithContext", self);
> nit nslogs...

Done.

[justincohen, 2014-12-02 01:57:20]

I have an iOS developer cert.  If I run the the test gyp, and build with Xcode
6.2 beta, how do I build for device?  What's missing?

[dmpatierno, 2014-12-02 03:01:43]

It will work fine if you build the test app and run manually using Xcode. But
when I run the test via command line (python gyptest.py -f xcode
test/ios/gyptest-watch.py), I get the following error:

=== BUILD TARGET WatchApp OF PROJECT watch WITH THE DEFAULT CONFIGURATION
(Default) ===

Check dependencies
CodeSign error: code signing is required for product type 'Watch Application' in
SDK 'iOS 8.2'

I also get the same error when running the existing 'gyptest-extension' test.
Does that one work for you?

[justincohen, 2014-12-03 00:31:04]

lgtm

https://codereview.chromium.org/762673002/diff/60001/test/ios/watch/watch.gyp
File test/ios/watch/watch.gyp (right):

https://codereview.chromium.org/762673002/diff/60001/test/ios/watch/watch.gyp...
test/ios/watch/watch.gyp:68: '<(PRODUCT_DIR)/WatchApp.app',
I think ninja is failing because there's no explicit output for WatchApp.app

https://codereview.chromium.org/762673002/diff/60001/test/ios/watch/watch.gyp...
test/ios/watch/watch.gyp:74: 'libraries': [
Doesn't this need Foundation.framework too?

https://codereview.chromium.org/762673002/diff/60001/test/ios/watch/watch.gyp...
test/ios/watch/watch.gyp:75:
'$(SDKROOT)/System/Library/Frameworks/WatchKit.framework',
Any idea why this shows up as a red (file not found) when opening in Xcode?  
Everything seems to link correctly, so I can't tell if it's a real problem.

[justincohen, 2014-12-03 00:32:08]

blah, I did not mean to hit 'quick lgtm'.  not lgtm, although it does look very
good.

I'd love to know why ninja doesn't work, since when I run the patch with fixed
dependencies and adding foundation, it seems to work.

[justincohen, 2014-12-03 16:51:31]

I happened to have this patched in while building chromios, and gyp seems to
think chromium is now an appex.  I haven't looked into why yet.  Does this patch
pass all gyptest ?

[dmpatierno, 2014-12-03 20:16:08]

On 2014/12/03 16:51:31, justincohen wrote:
> I happened to have this patched in while building chromios, and gyp seems to
> think chromium is now an appex.  I haven't looked into why yet.  Does this
patch
> pass all gyptest ?

I think I see the offending line in xcode_emulation.py (missing parens at the
end):

if self._IsIosAppExtension() or self._IsIosWatchKitExtension:

None of the tests catch this though, so I'll try to add one.

[dmpatierno, 2014-12-03 23:08:43]

On 2014/12/03 20:16:08, dmpatierno wrote:
> On 2014/12/03 16:51:31, justincohen wrote:
> > I happened to have this patched in while building chromios, and gyp seems to
> > think chromium is now an appex.  I haven't looked into why yet.  Does this
> patch
> > pass all gyptest ?
> 
> I think I see the offending line in xcode_emulation.py (missing parens at the
> end):
> 
> if self._IsIosAppExtension() or self._IsIosWatchKitExtension:
> 
> None of the tests catch this though, so I'll try to add one.

Actually, there are plenty of failing tests, but only using ninja when that
method is referenced. Sorry, I should have caught that myself; thanks for
pointing it out.

[dmpatierno, 2014-12-03 23:09:48]

https://codereview.chromium.org/762673002/diff/60001/test/ios/watch/watch.gyp
File test/ios/watch/watch.gyp (right):

https://codereview.chromium.org/762673002/diff/60001/test/ios/watch/watch.gyp...
test/ios/watch/watch.gyp:68: '<(PRODUCT_DIR)/WatchApp.app',
On 2014/12/03 00:31:04, justincohen wrote:
> I think ninja is failing because there's no explicit output for WatchApp.app

I can get the test to pass with ninja now, but I've been unable to find a
configuration that both ninja and xcode are happy with. If I force
SDKROOT=iphonesimulator8.2, xcode succeeds and ninja fails. If I remove the
simulator-specific lines, ninja succeeds and xcode fails. It looks like the
"extension" test just does the latter and fails for xcode runs. For now, I've
updated the watch test to do the same.

Any ideas?

https://codereview.chromium.org/762673002/diff/60001/test/ios/watch/watch.gyp...
test/ios/watch/watch.gyp:74: 'libraries': [
On 2014/12/03 00:31:04, justincohen wrote:
> Doesn't this need Foundation.framework too?

The simple reference app I made does not include the Foundation or UIKit
frameworks anywhere in the project file. I think Xcode 6 will parse the source
and add them automatically, so it doesn't actually need them here, but I agree
being explicit is better. Added.

https://codereview.chromium.org/762673002/diff/60001/test/ios/watch/watch.gyp...
test/ios/watch/watch.gyp:75:
'$(SDKROOT)/System/Library/Frameworks/WatchKit.framework',
On 2014/12/03 00:31:04, justincohen wrote:
> Any idea why this shows up as a red (file not found) when opening in Xcode?  
> Everything seems to link correctly, so I can't tell if it's a real problem.

I noticed this too. Everything compiles, runs, and works though. No idea why
Xcode colors it red.

[justincohen, 2014-12-04 17:21:36]

justincohen@chromium.org changed reviewers:
+ sdefresne@chromium.org

[justincohen, 2014-12-04 17:21:37]

It looks like everything works, and will not break the bots since they run an
older xcode?  LGTM with optional/unrelated addition, assuming everything
succeeds on your side.

Can you please ask sdefresne@ to also look over?

I wonder if we should file a bug about gyptest not loading certs correctly,
especially if we ever fix the bots.

Thanks!

https://codereview.chromium.org/762673002/diff/60001/test/ios/watch/watch.gyp
File test/ios/watch/watch.gyp (right):

https://codereview.chromium.org/762673002/diff/60001/test/ios/watch/watch.gyp...
test/ios/watch/watch.gyp:68: '<(PRODUCT_DIR)/WatchApp.app',
On 2014/12/03 23:09:48, dmpatierno wrote:
> On 2014/12/03 00:31:04, justincohen wrote:
> > I think ninja is failing because there's no explicit output for WatchApp.app
> 
> I can get the test to pass with ninja now, but I've been unable to find a
> configuration that both ninja and xcode are happy with. If I force
> SDKROOT=iphonesimulator8.2, xcode succeeds and ninja fails. If I remove the
> simulator-specific lines, ninja succeeds and xcode fails. It looks like the
> "extension" test just does the latter and fails for xcode runs. For now, I've
> updated the watch test to do the same.
> 
> Any ideas?

It works fine for me if I run from within Xcode, and not from the command line
gyptest.  sdefresne pointed out that gyptest messes with $HOME which breaks
security's ability to load the provisoining profiles.  He suggested you need to
create ${TEST_BASE}/Library/Keychains and copy recursively the content of
~/Library/Keychains there.   probably the same thing for "$HOME}/ 

Or just make sure it works in Xcode natively....

The extension.gyp is missing 'CODE_SIGN_IDENTITY[sdk=iphoneos*]': 'iPhone
Developer' for both targets.  If I add them there, extension also passes when
run natively in Xcode.  I don't think sdefrense@ would object if you add those
two lines, e.g.

diff --git a/test/ios/extension/extension.gyp b/test/ios/extension/extension.gyp
index 6fa468c..0c20f6a 100644
--- a/test/ios/extension/extension.gyp
+++ b/test/ios/extension/extension.gyp
@@ -48,6 +48,7 @@
         'ARCHS': [ 'armv7' ],
         'SDKROOT': 'iphoneos',
         'IPHONEOS_DEPLOYMENT_TARGET': '7.0',
+        'CODE_SIGN_IDENTITY[sdk=iphoneos*]': 'iPhone Developer'
       },
     },
     {
@@ -76,6 +77,7 @@
         'ARCHS': [ 'armv7' ],
         'SDKROOT': 'iphoneos',
         'IPHONEOS_DEPLOYMENT_TARGET': '7.0',
+        'CODE_SIGN_IDENTITY[sdk=iphoneos*]': 'iPhone Developer'
       },
     },
   ],

[sdefresne, 2014-12-05 10:48:51]

LGTM

Could you please file a bug so that gtest sets up correctly the certificates,
provisioning profiles, etc. when running tests? I think I know how to fix it
(i.e. have gtest copy the required files into the temporary HOME directory when
running on Mac).

[dmpatierno, 2014-12-09 00:42:33]

Added code sign identity lines to extension.gyp and filed bug
https://code.google.com/p/gyp/issues/detail?id=475

[Justin Cohen (wrong one), 2014-12-10 20:59:00]

Committed patchset #7 (id:120001) manually as 2014 (presubmit successful).