chrome/browser/chromeos/options/vpn_config_view.cc - Issue 762633002: Use NetworkConnectionObserver to trigger connect failure notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/options/vpn_config_view.cc

Issue 762633002: Use NetworkConnectionObserver to trigger connect failure notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/options/vpn_config_view.cc

diff --git a/chrome/browser/chromeos/options/vpn_config_view.cc b/chrome/browser/chromeos/options/vpn_config_view.cc

index 6cda28c3cdbbbdaa95df05d213c093c2547ab3b4..024bbafc905c9c544d57d7ad9d12e6c032e713db 100644

--- a/chrome/browser/chromeos/options/vpn_config_view.cc

+++ b/chrome/browser/chromeos/options/vpn_config_view.cc

@@ -1000,7 +1000,7 @@ void VPNConfigView::UpdateErrorLabel() {

const NetworkState* vpn = NetworkHandler::Get()->network_state_handler()->

GetNetworkState(service_path_);

if (vpn && vpn->connection_state() == shill::kStateFailure)

- error_msg = ui::NetworkConnect::Get()->GetErrorString(

+ error_msg = ui::NetworkConnect::Get()->GetShillErrorString(

vpn->last_error(), vpn->path());

}

if (!error_msg.empty()) {

« no previous file with comments | « no previous file | chrome/browser/chromeos/options/wifi_config_view.cc » ('j') | no next file with comments »