Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 762563003: Roll gwt to 2.7.0 (from 2.5.1) (Closed)

Created:
6 years ago by cjhopman
Modified:
6 years ago
Reviewers:
nyquist
Base URL:
https://code.google.com/p/dom-distiller/@master
Visibility:
Public.

Description

Roll gwt to 2.7.0 (from 2.5.1) See the changes to gwt here: http://www.gwtproject.org/release-notes.html This has several big-ish changes for us. 1. We now use java 7 (instead of 5) 2. We no longer use gwt-exporter (gwt now has built-in export support) 3. We now use the SingleScriptLinker (which changes slightly how we extract javascript) This time we don't include the docs/ or samples/ folders of the gwt sdk. R=nyquist@chromium.org Committed: ed4df25cb0e4d94db423b55e60a6c60caf971844

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -97 lines) Patch
M .gitignore View 1 chunk +5 lines, -5 lines 0 comments Download
M build.xml View 10 chunks +20 lines, -24 lines 0 comments Download
M create_standalone_js.py View 1 3 chunks +32 lines, -29 lines 0 comments Download
M extension/extract.js View 1 chunk +1 line, -1 line 0 comments Download
M src/DomDistiller.gwt.xml View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/com/dom_distiller/client/DomDistiller.java View 1 chunk +6 lines, -5 lines 0 comments Download
M src/com/dom_distiller/client/DomDistillerEntry.java View 2 chunks +0 lines, -3 lines 0 comments Download
M test/com/dom_distiller/DomDistillerJUnit.gwt.xml View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/gwt-2.7.0/COPYING View 3 chunks +0 lines, -15 lines 0 comments Download
A + third_party/gwt-2.7.0/COPYING.html View 2 chunks +2 lines, -12 lines 0 comments Download
A + third_party/gwt-2.7.0/about.html View 3 chunks +2 lines, -3 lines 0 comments Download
A + third_party/gwt-2.7.0/about.txt View 2 chunks +2 lines, -3 lines 0 comments Download
A third_party/gwt-2.7.0/gwt-api-checker.jar View Binary file 0 comments Download
A third_party/gwt-2.7.0/gwt-codeserver.jar View Binary file 0 comments Download
A + third_party/gwt-2.7.0/gwt-dev.jar View Binary file 0 comments Download
A + third_party/gwt-2.7.0/gwt-elemental.jar View Binary file 0 comments Download
A + third_party/gwt-2.7.0/gwt-ll.dll View Binary file 0 comments Download
A + third_party/gwt-2.7.0/gwt-module.dtd View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/gwt-2.7.0/gwt-servlet.jar View Binary file 0 comments Download
A + third_party/gwt-2.7.0/gwt-servlet-deps.jar View Binary file 0 comments Download
A + third_party/gwt-2.7.0/gwt-user.jar View Binary file 0 comments Download
A + third_party/gwt-2.7.0/i18nCreator View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/gwt-2.7.0/i18nCreator.cmd View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/gwt-2.7.0/release_notes.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/gwt-2.7.0/requestfactory-apt.jar View Binary file 0 comments Download
A third_party/gwt-2.7.0/requestfactory-apt-src.jar View Binary file 0 comments Download
A third_party/gwt-2.7.0/requestfactory-client.jar View Binary file 0 comments Download
A third_party/gwt-2.7.0/requestfactory-client+src.jar View Binary file 0 comments Download
A third_party/gwt-2.7.0/requestfactory-client-src.jar View Binary file 0 comments Download
A third_party/gwt-2.7.0/requestfactory-server.jar View Binary file 0 comments Download
A third_party/gwt-2.7.0/requestfactory-server+src.jar View Binary file 0 comments Download
A third_party/gwt-2.7.0/requestfactory-server-src.jar View Binary file 0 comments Download
A + third_party/gwt-2.7.0/validation-api-1.0.0.GA.jar View Binary file 0 comments Download
A + third_party/gwt-2.7.0/validation-api-1.0.0.GA-sources.jar View Binary file 0 comments Download
A + third_party/gwt-2.7.0/webAppCreator View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/gwt-2.7.0/webAppCreator.cmd View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
cjhopman
nyquist: * Here's a fun thanksgiving review for ya! I'll be deleting third_party/gwt-2.5.1 and third_party/gwt_exporter ...
6 years ago (2014-11-27 01:41:39 UTC) #2
nyquist
https://codereview.chromium.org/762563003/diff/1/create_standalone_js.py File create_standalone_js.py (right): https://codereview.chromium.org/762563003/diff/1/create_standalone_js.py#newcode26 create_standalone_js.py:26: marker = 'domdistiller();' Any reason why |marker| is defined ...
6 years ago (2014-12-02 06:31:03 UTC) #3
cjhopman
https://codereview.chromium.org/762563003/diff/1/create_standalone_js.py File create_standalone_js.py (right): https://codereview.chromium.org/762563003/diff/1/create_standalone_js.py#newcode26 create_standalone_js.py:26: marker = 'domdistiller();' On 2014/12/02 06:31:03, nyquist wrote: > ...
6 years ago (2014-12-02 20:10:36 UTC) #4
nyquist
lgtm
6 years ago (2014-12-02 21:20:23 UTC) #5
cjhopman
6 years ago (2014-12-02 21:37:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
ed4df25cb0e4d94db423b55e60a6c60caf971844 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698