Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 762513002: Fix PPIXEL_FORMAT_NV21 returned string (Closed)

Created:
6 years ago by zhaoze.zhou
Modified:
6 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix PPIXEL_FORMAT_NV21 returned string BUG=436651 In the case of PIXEL_FORMAT_NV21, the PixelFormatToString() function will return "YV12". This cl modify it to "NV21" Committed: https://crrev.com/f70d7d4bbce8652375235dab1f5434f6faa5e23f Cr-Commit-Position: refs/heads/master@{#305742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/video/capture/video_capture_types.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (4 generated)
zhaoze.zhou
vrk@chromium.org: Can you take a look? I am not sure the returned value is done ...
6 years ago (2014-11-25 19:45:54 UTC) #3
mcasas
On 2014/11/25 19:45:54, zhaoze.zhou wrote: > mailto:vrk@chromium.org: Can you take a look? I am not ...
6 years ago (2014-11-25 21:18:50 UTC) #4
zhaoze.zhou
On 2014/11/25 21:18:50, mcasas wrote: > On 2014/11/25 19:45:54, zhaoze.zhou wrote: > > mailto:vrk@chromium.org: Can ...
6 years ago (2014-11-25 21:24:21 UTC) #6
vrk (LEFT CHROMIUM)
Nit: looks like the bug is obvious, but could you add a BUG= link?
6 years ago (2014-11-25 22:48:01 UTC) #7
vrk (LEFT CHROMIUM)
Oops, didn't realize this was closed.
6 years ago (2014-11-25 22:48:30 UTC) #8
zhaoze.zhou
On 2014/11/25 22:48:30, vrk wrote: > Oops, didn't realize this was closed. https://codereview.chromium.org/416553002 This is ...
6 years ago (2014-11-25 22:52:35 UTC) #9
vrk (LEFT CHROMIUM)
Haha, that's my mistake. I shouldn't have LG'd CL 416553002 since it doesn't have a ...
6 years ago (2014-11-25 23:04:02 UTC) #10
zhaoze.zhou
On 2014/11/25 23:04:02, vrk wrote: > Haha, that's my mistake. I shouldn't have LG'd CL ...
6 years ago (2014-11-25 23:34:22 UTC) #11
vrk (LEFT CHROMIUM)
lgtm
6 years ago (2014-11-25 23:35:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/762513002/1
6 years ago (2014-11-25 23:36:39 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-26 00:51:55 UTC) #15
commit-bot: I haz the power
6 years ago (2014-11-26 00:53:10 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f70d7d4bbce8652375235dab1f5434f6faa5e23f
Cr-Commit-Position: refs/heads/master@{#305742}

Powered by Google App Engine
This is Rietveld 408576698