Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 762493006: [arm] Fix recognition of VNEG. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix #

Total comments: 2

Patch Set 3 : Fix signbit #

Patch Set 4 : std::signbit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -13 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 3 chunks +11 lines, -12 lines 0 comments Download
M src/compiler/node-matchers.h View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M test/mjsunit/asm/float64mul.js View 1 1 chunk +11 lines, -1 line 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
PTAL
6 years ago (2014-11-26 09:42:38 UTC) #2
Sven Panne
LGTM with a nit https://codereview.chromium.org/762493006/diff/20001/src/compiler/node-matchers.h File src/compiler/node-matchers.h (right): https://codereview.chromium.org/762493006/diff/20001/src/compiler/node-matchers.h#newcode108 src/compiler/node-matchers.h:108: return this->Is(0.0) && std::signbit(this->Value()); std::signbit ...
6 years ago (2014-11-26 09:48:33 UTC) #3
Benedikt Meurer
Committed patchset #3 (id:40001) manually as 2aed882fe74dbf9210159babe30fedccd900e7cf (presubmit successful).
6 years ago (2014-11-26 10:46:43 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/762493006/diff/20001/src/compiler/node-matchers.h File src/compiler/node-matchers.h (right): https://codereview.chromium.org/762493006/diff/20001/src/compiler/node-matchers.h#newcode108 src/compiler/node-matchers.h:108: return this->Is(0.0) && std::signbit(this->Value()); On 2014/11/26 09:48:33, Sven Panne ...
6 years ago (2014-11-26 10:47:19 UTC) #5
Michael Achenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/751653004/ by machenbach@chromium.org. ...
6 years ago (2014-11-26 11:06:17 UTC) #6
Benedikt Meurer
6 years ago (2014-11-26 11:19:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
560b0c4534741cab40bcc0369997aab7091b56fd (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698