Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 762493005: Add scale and skew to C canvas API (Closed)

Created:
6 years ago by abarth-chromium
Modified:
6 years ago
Reviewers:
reed2, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Now with radians #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M include/c/sk_canvas.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/c/sk_surface.cpp View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
abarth-chromium
6 years ago (2014-11-26 05:44:25 UTC) #1
reed1
https://codereview.chromium.org/762493005/diff/1/include/c/sk_canvas.h File include/c/sk_canvas.h (right): https://codereview.chromium.org/762493005/diff/1/include/c/sk_canvas.h#newcode24 include/c/sk_canvas.h:24: void sk_canvas_rotate(sk_canvas_t*, float degrees); I've always felt a little ...
6 years ago (2014-12-01 20:25:09 UTC) #3
abarth-chromium
Done. I've made the API explicit about whether it's in degrees or radians and added ...
6 years ago (2014-12-01 21:31:54 UTC) #4
reed1
lgtm
6 years ago (2014-12-01 21:39:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/762493005/20001
6 years ago (2014-12-01 21:54:38 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-01 22:04:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2fc6ea62ce61c3a2b2d9b74a3fbe6b388b5d7558

Powered by Google App Engine
This is Rietveld 408576698