Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 762453002: Eliminate static initializers in SkColor_SSE2.h. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
mtklein, qiankun1, reed1
CC:
reviews_skia.org, qiankun
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Eliminate static initializers in SkColor_SSE2.h. Chrome hates static initializers. Two global masks can become a single local mask instead. Perf looks like a no-op: $ c --match bitmaprect_80 bitmap_RGBA --config 8888 bitmap_RGBA_8888_scale 13.7us -> 14.1us 1.03x bitmap_RGBA_8888_update_volatile 4.53us -> 4.6us 1.02x bitmap_RGBA_8888 4.55us -> 4.61us 1.01x bitmap_RGBA_8888_update 4.64us -> 4.67us 1.01x bitmap_RGBA_8888_A_source_stripes_three 9.66us -> 9.71us 1.01x bitmaprect_80_filter_identity 10.6us -> 10.5us 0.99x bitmaprect_80_nofilter_identity 10.5us -> 10.4us 0.99x TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/785982ed80ce43653f64640d04dae7eaf5e2f809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/opts/SkColor_opts_SSE2.h View 1 chunk +9 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mtklein
lgtm
6 years ago (2014-11-25 17:55:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/762453002/1
6 years ago (2014-11-25 17:56:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/785982ed80ce43653f64640d04dae7eaf5e2f809
6 years ago (2014-11-25 18:05:47 UTC) #5
qiankun1
Is there a tool to generate the data in your format? And where to find ...
6 years ago (2014-11-26 07:40:18 UTC) #7
mtklein
6 years ago (2014-11-26 14:46:41 UTC) #8
Message was sent while issue was closed.
On 2014/11/26 07:40:18, qiankun1 wrote:
> Is there a tool to generate the data in your format? And where to find some
skp
> files to testing?

Yes, skia/bin contains 'c' and 'compare' now.  If you sync to head and add
skia/bin to your path, you should be able to run that command literally.  Note
that compare is a Python script that depends on scipy for its implementation of
the Mann-Whitney U test.

We cannot redistribute .skp files, but you can use the directions here to
capture some of your own:
 
http://www.chromium.org/developers/how-tos/trace-event-profiling-tool/saving-...

Those directions look a little dated, but should work fine.  I think you really
only need to pass --enable-skia-benchmarking now.

Powered by Google App Engine
This is Rietveld 408576698