Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 762383004: Sync DOMImplementation.createDocument() IDL with spec (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
Mike West
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Project:
blink
Visibility:
Public.

Description

Sync DOMImplementation.createDocument() IDL with spec https://dom.spec.whatwg.org/#interface-domimplementation Because DOMImplementation::createDocument calls qualifiedName.isEmpty() there is no observable difference when qualifiedName is null. The added [TypeChecking=Interface] only affects the generated code for the doctype argument, where passing a non-null, non-DocType object will now throw an exception. Firefox Nightly and IE11 pass all of the new tests, with the exception of IE11 throwing an exception when the doctype argument is undefined. In other words, the cases where we now throw exceptions already throw exceptions in Firefox and IE, making it likely Web compatible. TEST=LayoutTests/fast/dom/DOMImplementation/createDocument-doctype-err.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
A LayoutTests/fast/dom/DOMImplementation/createDocument-doctype-err.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/DOMImplementation/createDocument-doctype-err-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/DOMImplementation/detached-doctype.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/observe-attributes.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMImplementation.idl View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
6 years ago (2014-12-08 11:34:17 UTC) #2
Mike West
LGTM.
6 years ago (2014-12-09 14:09:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/762383004/1
6 years ago (2014-12-09 14:26:26 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-09 14:28:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186779

Powered by Google App Engine
This is Rietveld 408576698