Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 762313002: Force path bounds in recording. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Force path bounds in recording. The use of SKTRacy isn't safe in SkPathRef. There are logical dependencies between the racy fields. Doesn't seem to affect recording performance: $ c --match skp --config nonrendering tabl_techmeme.skp 81.1us -> 86us 1.06x desk_mapsvg.skp 1.23ms -> 1.26ms 1.02x desk_yahooanswers.skp 114us -> 117us 1.02x tabl_sahadan.skp 70.9us -> 72us 1.02x desk_fontwipe.skp 31.6us -> 32us 1.01x tabl_cuteoverload.skp 414us -> 419us 1.01x desk_mobilenews.skp 503us -> 508us 1.01x desk_tigersvg.skp 150us -> 152us 1.01x desk_samoasvg.skp 608us -> 610us 1x tabl_digg.skp 636us -> 638us 1x tabl_pravda.skp 155us -> 156us 1x desk_jsfiddlehumperclip.skp 33.9us -> 33.9us 1x tabl_culturalsolutions.skp 295us -> 295us 1x desk_youtube.skp 447us -> 448us 1x desk_gws.skp 144us -> 144us 1x tabl_frantzen.skp 42us -> 42us 1x tabl_gspro.skp 50.1us -> 50us 1x tabl_googlecalendar.skp 165us -> 165us 1x desk_twitter.skp 359us -> 358us 1x desk_wordpress.skp 588us -> 583us 0.99x desk_jsfiddlebigcar.skp 32.8us -> 32.5us 0.99x desk_booking.skp 838us -> 827us 0.99x tabl_androidpolice.skp 1.42ms -> 1.4ms 0.99x desk_blogger.skp 378us -> 372us 0.98x desk_wowwiki.skp 1.11ms -> 1.09ms 0.98x tabl_cnet.skp 115us -> 112us 0.97x desk_silkfinance.skp 57.7us -> 55.9us 0.97x tabl_cnn.skp 136us -> 131us 0.97x desk_sfgate.skp 396us -> 377us 0.95x tabl_deviantart.skp 107us -> 102us 0.95x tabl_mozilla.skp 1.4ms -> 1.32ms 0.94x BUG=437511 Committed: https://skia.googlesource.com/skia/+/5c9c9be1f540e1895e65fbd244caae9135972143

Patch Set 1 #

Patch Set 2 : note #

Patch Set 3 : unused #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -47 lines) Patch
M include/core/SkDynamicAnnotations.h View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
M include/core/SkPathRef.h View 4 chunks +6 lines, -7 lines 0 comments Download
M src/core/SkPathRef.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein
6 years ago (2014-11-29 15:37:12 UTC) #2
reed1
lgtm
6 years ago (2014-12-01 14:08:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/762313002/40001
6 years ago (2014-12-01 14:47:50 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-01 15:00:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5c9c9be1f540e1895e65fbd244caae9135972143

Powered by Google App Engine
This is Rietveld 408576698