Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart

Issue 762213002: Support top-level field declaration and assignment in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart
diff --git a/pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart b/pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart
index 8a86eda794f38ae280b234949db7f41412ce990d..1539ba8b4f8cbd02169ca321156a86fafe28e74f 100644
--- a/pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart
+++ b/pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart
@@ -80,22 +80,26 @@ class ASTEmitter extends tree.Visitor<dynamic, Expression> {
FieldDefinition emitField(tree.FieldDefinition definition) {
currentElement = definition.element;
- visitStatement(definition.body);
- List<Statement> bodyParts;
- for (tree.Variable variable in variableNames.keys) {
- if (!declaredVariables.contains(variable)) {
- addDeclaration(variable);
+ Expression initializer;
+ if (definition.hasInitializer) {
+ visitStatement(definition.body);
+ List<Statement> bodyParts;
+ for (tree.Variable variable in variableNames.keys) {
+ if (!declaredVariables.contains(variable)) {
+ addDeclaration(variable);
+ }
}
- }
- if (variables.length > 0) {
- bodyParts = new List<Statement>();
- bodyParts.add(new VariableDeclarations(variables));
- bodyParts.addAll(statementBuffer);
- } else {
- bodyParts = statementBuffer;
+ if (variables.length > 0) {
+ bodyParts = new List<Statement>();
+ bodyParts.add(new VariableDeclarations(variables));
+ bodyParts.addAll(statementBuffer);
+ } else {
+ bodyParts = statementBuffer;
+ }
+ initializer = ensureExpression(bodyParts);
}
- return new FieldDefinition(definition.element, ensureExpression(bodyParts));
+ return new FieldDefinition(definition.element, initializer);
}
/// Returns an expression that will evaluate all of [bodyParts].

Powered by Google App Engine
This is Rietveld 408576698