pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart - Issue 762213002: Support top-level field declaration and assignment in analyzer2dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

Issue 762213002: Support top-level field declaration and assignment in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('K') | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

index 121cccc2c8c92739d199f02c173c7619b29a0004..c49c6a4f624da4569898b330e869be7198256082 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

@@ -45,10 +45,14 @@ class SExpressionStringifier extends Visitor<String> with Indentation {

String visitFieldDefinition(FieldDefinition node) {

String name = node.element.name;

- namer.useReturnName(node.returnContinuation);

- String body = indentBlock(() => visit(node.body));

- return '$indentation(FieldDefinition $name (return)\n'

- '$body)';

+ if (node.hasInitializer) {

+ namer.useReturnName(node.returnContinuation);

+ String body = indentBlock(() => visit(node.body));

+ return '$indentation(FieldDefinition $name (return)\n'

+ '$body)';

+ } else {

+ return '$indentation(FieldDefinition $name)';

+ }

}

String visitLetPrim(LetPrim node) {