pkg/compiler/lib/src/cps_ir/constant_propagation.dart - Issue 762213002: Support top-level field declaration and assignment in analyzer2dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/constant_propagation.dart

Issue 762213002: Support top-level field declaration and assignment in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analyzer2dart/lib/src/cps_generator.dart ('K') | « pkg/analyzer2dart/test/test_helper.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart » ('j') | pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/cps_ir/constant_propagation.dart

diff --git a/pkg/compiler/lib/src/cps_ir/constant_propagation.dart b/pkg/compiler/lib/src/cps_ir/constant_propagation.dart

index a6da66be1402f03f61a67e6027f9931f3c076170..975a53180db7b95d9d15cc200b2b5e7cb0901305 100644

--- a/pkg/compiler/lib/src/cps_ir/constant_propagation.dart

+++ b/pkg/compiler/lib/src/cps_ir/constant_propagation.dart

@@ -49,6 +49,7 @@ class ConstantPropagator extends Pass {

}

void rewriteFieldDefinition(FieldDefinition root) {

+ if (!root.hasInitializer) return;

_rewriteExecutableDefinition(root);

}

@@ -312,7 +313,9 @@ class _ConstPropagationVisitor extends Visitor {

}

void visitFieldDefinition(FieldDefinition node) {

- setReachable(node.body);

+ if (node.hasInitializer) {

+ setReachable(node.body);

+ }

}

// Expressions.