Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 762163002: Abstract platform in perf runner. (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
6 years ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Abstract platform in perf runner. This is basically a refactoring that extracts desktop specific code into a separate class. Also adds flags for android runs (not used yet). BUG=chromium:374740 LOG=n TEST=python -m unittest run_perf_test NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -18 lines) Patch
M tools/run_perf.py View 4 chunks +64 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
PTAL
6 years ago (2014-11-28 12:35:28 UTC) #2
ulan
lgtm
6 years ago (2014-11-28 13:18:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/762163002/1
6 years ago (2014-11-28 16:45:13 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-28 18:39:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698