Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 76213004: fix bench so that if SK_SUPPORTS_GPU even when not provided as compiler option (Closed)

Created:
7 years, 1 month ago by djsollen
Modified:
7 years, 1 month ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

fix bench so that if SK_SUPPORTS_GPU even when not provided as compiler option In the case that SK_SUPPORTS_GPU is not provided to the compiler the value is eithe defined in in the SkUserConfig.h or SkPostConfig.h. Prior to this change those headers were not read prior to trying to include the GPU headers which resulted in a failed compile. R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=12309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M bench/benchmain.cpp View 3 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
djsollen
7 years, 1 month ago (2013-11-19 15:55:35 UTC) #1
bsalomon
lgtm
7 years, 1 month ago (2013-11-19 16:50:43 UTC) #2
djsollen
7 years, 1 month ago (2013-11-20 13:15:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12309 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698