Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3965)

Unified Diff: chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

Issue 762113004: SpokenFeedbackTest.NavigateAppLaunchers: Fix for experimental app list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app-list-experimental-browser-tests
Patch Set: Change bug number in TODO. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
diff --git a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc b/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
index 3c86d5907ad0b1a0ac8eb597975161eb1b707340..16768e1c35296ea6a365f3b0521ec5df00a5950e 100644
--- a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
+++ b/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
@@ -38,6 +38,7 @@
#include "extensions/browser/extension_host.h"
#include "extensions/browser/process_manager.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/app_list/app_list_switches.h"
#include "ui/base/test/ui_controls.h"
#include "ui/views/widget/widget.h"
@@ -316,14 +317,21 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, NavigateAppLauncher) {
}
SendKeyPress(ui::VKEY_RETURN);
+ // TODO(mgiuca): This is incorrect behaviour; it should read out "Search, text
+ // box" or similar (see http://crbug.com/386826).
EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), ", text box"));
- SendKeyPress(ui::VKEY_DOWN);
- // Chrom* appears twice because the accessibility system uses the first app as
- // the accessibility context.
- EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "Chrom*,"));
- EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "Chrom*,"));
- EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "button"));
+ // TODO(mgiuca): The next part of the test fails in the experimental app list,
+ // because there is no keyboard navigation (see http://crbug.com/438568). Only
+ // check this in the classic app launcher.
+ if (!app_list::switches::IsExperimentalAppListEnabled()) {
+ SendKeyPress(ui::VKEY_DOWN);
+ // Chrom* appears twice because the accessibility system uses the first app
+ // as the accessibility context.
+ EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "Chrom*,"));
+ EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "Chrom*,"));
+ EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "button"));
+ }
}
IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, OpenStatusTray) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698