Issue 762113003: Add extra safety check to the EGL context setup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 762113003: Add extra safety check to the EGL context setup. (Closed)

Created:
6 years ago by joakim.landberg

Modified:
6 years ago

Reviewers:
mtklein, henrik.smiding, djsollen, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add extra safety check to the EGL context setup. Adds a check to make sure eglChooseConfig actually found a valid config. Besides checking for EGL errors, we also have to handle the case when no matching configs are found, i.e when num_config is 0. BUG=skia: Committed: https://skia.googlesource.com/skia/+/bb25e44593ff9c318d9fe1dbb5cf30bc2b89eb76

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/gpu/gl/egl/SkCreatePlatformGLContext_egl.cpp	View		2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/762113003/1

6 years ago (2014-12-01 14:26:40 UTC) #7

commit-bot: I haz the power

6 years ago (2014-12-01 14:46:04 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bb25e44593ff9c318d9fe1dbb5cf30bc2b89eb76

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages