Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 7621002: Send only one byte of data in the first CBC encrypted aplication data (Closed)

Created:
7 years, 9 months ago by wtc
Modified:
7 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Send only one byte of data in the first CBC encrypted aplication data record. This randomizes the IV in a backward compatible manner. R=agl@chromium.org BUG=87159 TEST=HTTPS sites continue to work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97269

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove TABs at the end of lines. #

Patch Set 3 : Remove space at the end of a line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -2 lines) Patch
M net/socket/ssl_client_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/third_party/nss/README.chromium View 1 chunk +6 lines, -0 lines 0 comments Download
M net/third_party/nss/patches/applypatches.sh View 1 chunk +2 lines, -0 lines 0 comments Download
A net/third_party/nss/patches/cbcrandomiv.patch View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/ssl3con.c View 1 2 3 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
wtc
7 years, 9 months ago (2011-08-11 02:43:13 UTC) #1
agl
LGTM http://codereview.chromium.org/7621002/diff/1/net/third_party/nss/ssl/ssl3con.c File net/third_party/nss/ssl/ssl3con.c (right): http://codereview.chromium.org/7621002/diff/1/net/third_party/nss/ssl/ssl3con.c#newcode2351 net/third_party/nss/ssl/ssl3con.c:2351: ssl_GetSpecReadLock(ss); nit: stray tab on the end of ...
7 years, 9 months ago (2011-08-11 04:28:03 UTC) #2
commit-bot: I haz the power
7 years, 9 months ago (2011-08-18 02:32:19 UTC) #3
Change committed as 97269

Powered by Google App Engine
This is Rietveld 408576698