Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 7621: * Optimized the bad-char table of Boyer-Moore (Closed)

Created:
12 years, 2 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
olehougaard
CC:
v8-dev
Visibility:
Public.

Description

Changed Boyer-Moore's bad-char table code: - Reduce it to half size if the pattern is ASCII, saving on initialization - If pattern is ASCII and subject is not, any non-ASCII char can cause a full pattern-length shift, even if we haven't indexed the entire pattern. - Use memset to initialize buffer in the common case where the pattern is shorter than the max significant suffix limit.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M src/runtime.cc View 7 chunks +27 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Lasse Reichstein
12 years, 2 months ago (2008-10-17 10:00:05 UTC) #1
Small code review.

Powered by Google App Engine
This is Rietveld 408576698