sky/engine/core/rendering/RenderFlexibleBox.cpp - Issue 762073002: Split more Paragraph-specific code from RenderBlock into RenderParagraph

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderFlexibleBox.cpp

Issue 762073002: Split more Paragraph-specific code from RenderBlock into RenderParagraph (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/core/rendering/RenderFlexibleBox.cpp

diff --git a/sky/engine/core/rendering/RenderFlexibleBox.cpp b/sky/engine/core/rendering/RenderFlexibleBox.cpp

index b40df33a84542aa0c8956dea80309c94fb146182..349314e53e9c1dfbec3fa01f01f339091228d59a 100644

--- a/sky/engine/core/rendering/RenderFlexibleBox.cpp

+++ b/sky/engine/core/rendering/RenderFlexibleBox.cpp

@@ -72,7 +72,6 @@ RenderFlexibleBox::RenderFlexibleBox(Element* element)

, m_orderIterator(this)

, m_numberOfInFlowChildrenOnFirstLine(-1)

{

- ASSERT(!isRenderParagraph());

rafaelw 2014/11/28 03:53:50 No point in asserting this since the class hierarc

ojan 2014/11/28 04:02:24 Lol. Yeah. This used to be !childrenInline().

}

RenderFlexibleBox::~RenderFlexibleBox()

« sky/engine/core/rendering/RenderBlock.cpp ('K') | « sky/engine/core/rendering/RenderBlockFlow.cpp ('k') | sky/engine/core/rendering/RenderParagraph.h » ('j') | no next file with comments »