Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 762073002: Split more Paragraph-specific code from RenderBlock into RenderParagraph (Closed)

Created:
6 years ago by rafaelw
Modified:
6 years ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Split more Paragraph-specific code from RenderBlock into RenderParagraph. In this episode: inlineSelectionGaps, markupTruncation, lineCount, heightForLineCount, lineAtIndex, lastLineBoxBaseline, firstLineBoxBaseline R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/90ab22af758b609bdaf6cb6a5ecdd0a8780563ec

Patch Set 1 #

Total comments: 6

Patch Set 2 : cr comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -165 lines) Patch
M sky/engine/core/rendering/RenderBlock.h View 1 4 chunks +3 lines, -8 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 7 chunks +43 lines, -98 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
M sky/engine/core/rendering/RenderFlexibleBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderParagraph.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderParagraph.cpp View 1 2 chunks +100 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rafaelw
https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/RenderBlock.h File sky/engine/core/rendering/RenderBlock.h (left): https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/RenderBlock.h#oldcode124 sky/engine/core/rendering/RenderBlock.h:124: void setHasMarkupTruncation(bool b) { m_hasMarkupTruncation = b; } note ...
6 years ago (2014-11-28 03:53:50 UTC) #2
ojan
lgtm https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/RenderBlock.cpp File sky/engine/core/rendering/RenderBlock.cpp (right): https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/RenderBlock.cpp#newcode1851 sky/engine/core/rendering/RenderBlock.cpp:1851: void RenderBlock::clearTruncation() FWIW, I think you can delete ...
6 years ago (2014-11-28 04:02:24 UTC) #3
rafaelw
6 years ago (2014-11-28 04:17:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
90ab22af758b609bdaf6cb6a5ecdd0a8780563ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698