Split more Paragraph-specific code from RenderBlock into RenderParagraph

Split more Paragraph-specific code from RenderBlock into RenderParagraph.

In this episode: inlineSelectionGaps, markupTruncation, lineCount, heightForLineCount, lineAtIndex, lastLineBoxBaseline, firstLineBoxBaseline

R=ojan@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/90ab22af758b609bdaf6cb6a5ecdd0a8780563ec

[rafaelw, 2014-11-28 03:51:14]

rafaelw@chromium.org changed reviewers:
+ ojan@chromium.org

[rafaelw, 2014-11-28 03:53:50]

https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBlock.h (left):

https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlock.h:124: void setHasMarkupTruncation(bool b)
{ m_hasMarkupTruncation = b; }
note that setHasMarkupTruncation was only ever set to false. It appears to have
been used by a deprecated flex-box layout

https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderFlexibleBox.cpp (left):

https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderFlexibleBox.cpp:75:
ASSERT(!isRenderParagraph());
No point in asserting this since the class hierarchy does.

[ojan, 2014-11-28 04:02:24]

lgtm

https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBlock.cpp (right):

https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlock.cpp:1851: void
RenderBlock::clearTruncation()
FWIW, I think you can delete this function too? Or maybe this is used for
text-overflow:ellipsis? FWIW, there is an ellipsis test checked in, but you need
to run it manually because we don't have pixel tests yet.

https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBlock.h (left):

https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlock.h:124: void setHasMarkupTruncation(bool b)
{ m_hasMarkupTruncation = b; }
On 2014/11/28 at 03:53:50, rafaelw wrote:
> note that setHasMarkupTruncation was only ever set to false. It appears to
have been used by a deprecated flex-box layout

Yup. deprecated flex + webkit-line-clamp. Did we remove webkit-line-clamp? We
should if we haven't already.

https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBlock.h (right):

https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlock.h:161: virtual int
heightForLineCount(int);
I wonder what uses these three outside of RenderParagraph. Maybe once you're
done with the refactoring here we'll be able to move these methods into
RenderParagraph.h and get rid of the RenderBlock versions.

https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderFlexibleBox.cpp (left):

https://codereview.chromium.org/762073002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderFlexibleBox.cpp:75:
ASSERT(!isRenderParagraph());
On 2014/11/28 at 03:53:50, rafaelw wrote:
> No point in asserting this since the class hierarchy does.

Lol. Yeah. This used to be !childrenInline().

[rafaelw, 2014-11-28 04:17:15]

Committed patchset #2 (id:20001) manually as
90ab22af758b609bdaf6cb6a5ecdd0a8780563ec (presubmit successful).