Issue 762001: Assign specialized array functions only once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 762001: Assign specialized array functions only once. (Closed)

Created:
10 years, 9 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Assign specialized array functions only once. Previous commit (4068) had a side-effect that specialized array functions weren't constant functions any more (as they were reassigned).

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -122 lines)			Patch
M	src/array.js	View	2 chunks	+36 lines, -45 lines	0 comments	Download
M	src/bootstrapper.cc	View	3 chunks	+0 lines, -77 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

antonm

Mads, may you have a look? It should fix perf regression I introduced.

10 years, 9 months ago (2010-03-09 22:24:44 UTC) #1

Mads Ager (chromium)

10 years, 9 months ago (2010-03-10 08:16:34 UTC) #2

For the record this LGTM.  It is included in another changelist now.

Expand Messages | Collapse Messages