Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 761983002: Support for map literals in cps js emitter (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library code_generator; 5 library code_generator;
6 6
7 import 'glue.dart'; 7 import 'glue.dart';
8 8
9 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir; 9 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir;
10 import '../../js/js.dart' as js; 10 import '../../js/js.dart' as js;
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 return giveup(node); 161 return giveup(node);
162 // TODO: implement visitFunctionExpression 162 // TODO: implement visitFunctionExpression
163 } 163 }
164 164
165 js.Expression compileConstant(ParameterElement parameter) { 165 js.Expression compileConstant(ParameterElement parameter) {
166 return buildConstant(glue.getConstantForVariable(parameter).value); 166 return buildConstant(glue.getConstantForVariable(parameter).value);
167 } 167 }
168 168
169 js.Expression buildStaticInvoke(Selector selector, 169 js.Expression buildStaticInvoke(Selector selector,
170 Element target, 170 Element target,
171 List<tree_ir.Expression> arguments) { 171 List<js.Expression> arguments) {
172 registry.registerStaticInvocation(target.declaration); 172 registry.registerStaticInvocation(target.declaration);
173 173
174 js.Expression elementAccess = glue.elementAccess(target); 174 js.Expression elementAccess = glue.elementAccess(target);
175 List<js.Expression> compiledArguments = 175 List<js.Expression> compiledArguments =
176 selector.makeArgumentsList(arguments, target.implementation, 176 selector.makeArgumentsList(target.implementation,
177 visitExpression, 177 arguments,
178 compileConstant); 178 compileConstant);
179 return new js.Call(elementAccess, compiledArguments); 179 return new js.Call(elementAccess, compiledArguments);
180 } 180 }
181 181
182 @override 182 @override
183 js.Expression visitInvokeConstructor(tree_ir.InvokeConstructor node) { 183 js.Expression visitInvokeConstructor(tree_ir.InvokeConstructor node) {
184 if (node.constant != null) return giveup(node); 184 if (node.constant != null) return giveup(node);
185 return buildStaticInvoke(node.selector, node.target, node.arguments); 185 return buildStaticInvoke(node.selector,
186 node.target,
187 visitArguments(node.arguments));
186 } 188 }
187 189
188 void registerMethodInvoke(tree_ir.InvokeMethod node) { 190 void registerMethodInvoke(tree_ir.InvokeMethod node) {
189 Selector selector = node.selector; 191 Selector selector = node.selector;
190 // TODO(sigurdm): We should find a better place to register the call. 192 // TODO(sigurdm): We should find a better place to register the call.
191 Selector call = new Selector.callClosureFrom(selector); 193 Selector call = new Selector.callClosureFrom(selector);
192 registry.registerDynamicInvocation(call); 194 registry.registerDynamicInvocation(call);
193 registry.registerDynamicInvocation(selector); 195 registry.registerDynamicInvocation(selector);
194 } 196 }
195 197
196 @override 198 @override
197 js.Expression visitInvokeMethod(tree_ir.InvokeMethod node) { 199 js.Expression visitInvokeMethod(tree_ir.InvokeMethod node) {
198 // TODO(sigurdm): Handle intercepted invocations. 200 // TODO(sigurdm): Handle intercepted invocations.
199 if (glue.isIntercepted(node.selector)) giveup(node); 201 if (glue.isIntercepted(node.selector)) giveup(node);
200 js.Expression receiver = visitExpression(node.receiver); 202 js.Expression receiver = visitExpression(node.receiver);
201 203
202 List<js.Expression> arguments = visitArguments(node.arguments); 204 List<js.Expression> arguments = visitArguments(node.arguments);
203 205
204 String methodName = glue.invocationName(node.selector); 206 String methodName = glue.invocationName(node.selector);
205 registerMethodInvoke(node); 207 registerMethodInvoke(node);
206 208
207 return js.propertyCall(receiver, methodName, arguments); 209 return js.propertyCall(receiver, methodName, arguments);
208 } 210 }
209 211
210 @override 212 @override
211 js.Expression visitInvokeStatic(tree_ir.InvokeStatic node) { 213 js.Expression visitInvokeStatic(tree_ir.InvokeStatic node) {
212 return buildStaticInvoke(node.selector, node.target, node.arguments); 214 return buildStaticInvoke(node.selector,
215 node.target,
216 visitArguments(node.arguments));
213 } 217 }
214 218
215 @override 219 @override
216 js.Expression visitInvokeSuperMethod(tree_ir.InvokeSuperMethod node) { 220 js.Expression visitInvokeSuperMethod(tree_ir.InvokeSuperMethod node) {
217 return giveup(node); 221 return giveup(node);
218 // TODO: implement visitInvokeSuperMethod 222 // TODO: implement visitInvokeSuperMethod
219 } 223 }
220 224
221 @override 225 @override
222 js.Expression visitLiteralList(tree_ir.LiteralList node) { 226 js.Expression visitLiteralList(tree_ir.LiteralList node) {
223 registry.registerInstantiatedClass(glue.listClass); 227 registry.registerInstantiatedClass(glue.listClass);
224 int length = node.values.length; 228 int length = node.values.length;
225 List<js.ArrayElement> entries = new List<js.ArrayElement>.generate(length, 229 List<js.ArrayElement> entries = new List<js.ArrayElement>.generate(length,
226 (int i) => new js.ArrayElement(i, visitExpression(node.values[i]))); 230 (int i) => new js.ArrayElement(i, visitExpression(node.values[i])));
227 return new js.ArrayInitializer(length, entries); 231 return new js.ArrayInitializer(length, entries);
228 } 232 }
229 233
230 @override 234 @override
231 js.Expression visitLiteralMap(tree_ir.LiteralMap node) { 235 js.Expression visitLiteralMap(tree_ir.LiteralMap node) {
232 return giveup(node); 236 ConstructorElement constructor;
233 // TODO: implement visitLiteralMap 237 if (node.entries.isEmpty) {
238 constructor = glue.mapLiteralConstructorEmpty;
239 } else {
240 constructor = glue.mapLiteralConstructor;
241 }
242 List<js.ArrayElement> entries =
243 new List<js.ArrayElement>(2 * node.entries.length);
244 for (int i = 0; i < node.entries.length; i++) {
245 js.Expression key = visitExpression(node.entries[i].key);
246 js.Expression value = visitExpression(node.entries[i].value);
247 entries[2 * i] = new js.ArrayElement(2 * i, key);
248 entries[2 * i + 1] = new js.ArrayElement(2 * i + 1, value);
249 }
250 List<js.Expression> args =
251 <js.Expression>[new js.ArrayInitializer(node.entries.length * 2,
252 entries)];
253 return buildStaticInvoke(
254 new Selector.call(constructor.name, constructor.library, 2),
255 constructor,
256 args);
234 } 257 }
235 258
236 @override 259 @override
237 js.Expression visitLogicalOperator(tree_ir.LogicalOperator node) { 260 js.Expression visitLogicalOperator(tree_ir.LogicalOperator node) {
238 return new js.Binary(node.operator, visit(node.left), visit(node.right)); 261 return new js.Binary(node.operator, visit(node.left), visit(node.right));
239 } 262 }
240 263
241 @override 264 @override
242 js.Expression visitNot(tree_ir.Not node) { 265 js.Expression visitNot(tree_ir.Not node) {
243 return new js.Prefix("!", visitExpression(node.operand)); 266 return new js.Prefix("!", visitExpression(node.operand));
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 accumulator.add( 414 accumulator.add(
392 buildWhile(new js.LiteralBool(true), node.body, node.label, node)); 415 buildWhile(new js.LiteralBool(true), node.body, node.label, node));
393 } 416 }
394 417
395 @override 418 @override
396 void visitReturn(tree_ir.Return node) { 419 void visitReturn(tree_ir.Return node) {
397 accumulator.add(new js.Return(visitExpression(node.value))); 420 accumulator.add(new js.Return(visitExpression(node.value)));
398 } 421 }
399 422
400 } 423 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698