[chromedriver] Change browser info parser to support Lollipop WebView apps

chrome/test/chromedriver/chrome/browser_info_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/chrome/browser_info.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
@@ skipping 36 matching lines @@
   BrowserInfo browser_info;
   const int default_blink_revision = browser_info.blink_revision;
   Status status = ParseBrowserInfo(data, &browser_info);
   ASSERT_TRUE(status.IsOk());
   ASSERT_EQ("chrome", browser_info.browser_name);
   ASSERT_EQ("37.0.2062.124", browser_info.browser_version);
   ASSERT_EQ(2062, browser_info.build_no);
   ASSERT_EQ(default_blink_revision, browser_info.blink_revision);
 }
 
-TEST(ParseBrowserString, Chrome) {
-  std::string browser_name;
-  std::string browser_version;
-  int build_no;
+TEST(ParseBrowserString, KitKatWebView) {
+  BrowserInfo browser_info;
   Status status = ParseBrowserString(
-      "Chrome/37.0.2062.124", &browser_name, &browser_version, &build_no);
+      false, "Version/4.0 Chrome/30.0.0.0", &browser_info);
   ASSERT_TRUE(status.IsOk());
-  ASSERT_EQ("chrome", browser_name);
-  ASSERT_EQ("37.0.2062.124", browser_version);
-  ASSERT_EQ(2062, build_no);
+  ASSERT_EQ("webview", browser_info.browser_name);
+  ASSERT_EQ(std::string(), browser_info.browser_version);
+  ASSERT_EQ(kToTBuildNo, browser_info.build_no);
+}
+
+TEST(ParseBrowserString, LollipopWebView) {
+  BrowserInfo browser_info;
+  Status status = ParseBrowserString(
+      true, "Chrome/37.0.0.0", &browser_info);
+  ASSERT_TRUE(status.IsOk());
+  ASSERT_EQ("webview", browser_info.browser_name);
+  ASSERT_EQ(std::string(), browser_info.browser_version);
+  ASSERT_EQ(kToTBuildNo, browser_info.build_no);
+}
+
+TEST(ParseBrowserString, AndroidChrome) {
+  BrowserInfo browser_info;
+  Status status = ParseBrowserString(
+      true, "Chrome/39.0.2171.59", &browser_info);
+  ASSERT_TRUE(status.IsOk());
+  ASSERT_EQ("chrome", browser_info.browser_name);
+  ASSERT_EQ("39.0.2171.59", browser_info.browser_version);
+  ASSERT_EQ(2171, browser_info.build_no);
+}
+
+TEST(ParseBrowserString, DesktopChrome) {
+  BrowserInfo browser_info;
+  Status status = ParseBrowserString(
+      false, "Chrome/39.0.2171.59", &browser_info);
+  ASSERT_TRUE(status.IsOk());
+  ASSERT_EQ("chrome", browser_info.browser_name);
+  ASSERT_EQ("39.0.2171.59", browser_info.browser_version);
+  ASSERT_EQ(2171, browser_info.build_no);
 }
 
 TEST(ParseBlinkVersionString, GitHash) {
   int rev = -1;
   Status status = ParseBlinkVersionString(
       "537.36 (@28f741cfcabffe68a9c12c4e7152569c906bd88f)", &rev);
   ASSERT_TRUE(status.IsOk());
   ASSERT_EQ(-1, rev);
 }
 
@@ skipping 12 matching lines @@
   ASSERT_TRUE(IsGitHash("1493aa5"));
 }
 
 TEST(IsGitHash, GitHashWithUpperCaseCharacters) {
   ASSERT_TRUE(IsGitHash("28F741CFCABFFE68A9C12C4E7152569C906BD88F"));
 }
 
 TEST(IsGitHash, SvnRevision) {
   ASSERT_FALSE(IsGitHash("159105"));
 }