[chromedriver] Change browser info parser to support Lollipop WebView apps

[chromedriver] Change browser info parser to support Lollipop WebView apps

BUG=chromedriver:845
Committed: https://crrev.com/31b6a93e15c029f5ccba9b4a9af47366ad5205f0
Cr-Commit-Position: refs/heads/master@{#307119}

[samuong, 2014-12-05 01:29:54]

samuong@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2014-12-05 22:10:55]

lgtm with nits

https://codereview.chromium.org/761963007/diff/1/chrome/test/chromedriver/chr...
File chrome/test/chromedriver/chrome/browser_info.cc (right):

https://codereview.chromium.org/761963007/diff/1/chrome/test/chromedriver/chr...
chrome/test/chromedriver/chrome/browser_info.cc:76: if (build_no != 0) {
Would it be possible that |build_no| is un-initialized?

https://codereview.chromium.org/761963007/diff/1/chrome/test/chromedriver/chr...
chrome/test/chromedriver/chrome/browser_info.cc:84: if
(browser_string.find("Version/") == 0u || (is_android && build_no == 0)) {
Maybe add some comment so that we know which condition is for which case?

[samuong, 2014-12-05 22:17:57]

https://codereview.chromium.org/761963007/diff/1/chrome/test/chromedriver/chr...
File chrome/test/chromedriver/chrome/browser_info.cc (right):

https://codereview.chromium.org/761963007/diff/1/chrome/test/chromedriver/chr...
chrome/test/chromedriver/chrome/browser_info.cc:76: if (build_no != 0) {
On 2014/12/05 22:10:54, Shuotao wrote:
> Would it be possible that |build_no| is un-initialized?

The call to StringToInt() should return false if it leaves build_no
uninitialized, so this is already checked for.

https://codereview.chromium.org/761963007/diff/1/chrome/test/chromedriver/chr...
chrome/test/chromedriver/chrome/browser_info.cc:84: if
(browser_string.find("Version/") == 0u || (is_android && build_no == 0)) {
On 2014/12/05 22:10:54, Shuotao wrote:
> Maybe add some comment so that we know which condition is for which case?

Done.

[samuong, 2014-12-05 22:18:00]

The CQ bit was checked by samuong@chromium.org

[commit-bot: I haz the power, 2014-12-05 22:18:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/761963007/20001

[commit-bot: I haz the power, 2014-12-05 22:42:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-05 22:42:35]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[samuong, 2014-12-05 23:15:48]

The CQ bit was checked by samuong@chromium.org

[commit-bot: I haz the power, 2014-12-05 23:16:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/761963007/40001

[commit-bot: I haz the power, 2014-12-05 23:58:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-05 23:59:47]

Patchset 3 (id:??) landed as
https://crrev.com/31b6a93e15c029f5ccba9b4a9af47366ad5205f0
Cr-Commit-Position: refs/heads/master@{#307119}