Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 761923004: Keep alive ServiceWorkers when devtools is attached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index 7f6f74900370982846209114b62bd8df8375995f..37425a826dcb72b113ad7582d2f6f3454ee02523 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -248,11 +248,14 @@ class CONTENT_EXPORT ServiceWorkerVersion
void Doom();
bool is_doomed() const { return is_doomed_; }
+ void SetDevToolsAttached(bool attached);
+
private:
friend class base::RefCounted<ServiceWorkerVersion>;
FRIEND_TEST_ALL_PREFIXES(ServiceWorkerControlleeRequestHandlerTest,
ActivateWaitingVersion);
FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, ScheduleStopWorker);
+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, KeepAlive);
FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, ListenerAvailability);
typedef ServiceWorkerVersion self;
typedef std::map<ServiceWorkerProviderHost*, int> ControlleeMap;
@@ -306,6 +309,9 @@ class CONTENT_EXPORT ServiceWorkerVersion
void OnFocusClientFinished(int request_id, bool result);
void ScheduleStopWorker();
+ void StopWorkerIfIdle();
+ bool HasInflightRequests() const;
+
void DoomInternal();
const int64 version_id_;
@@ -319,7 +325,8 @@ class CONTENT_EXPORT ServiceWorkerVersion
std::vector<StatusCallback> stop_callbacks_;
std::vector<base::Closure> status_change_callbacks_;
- // Message callbacks.
+ // Message callbacks. (Update HasInflightRequests() too when you update this
+ // list.)
IDMap<StatusCallback, IDMapOwnPointer> activate_callbacks_;
IDMap<StatusCallback, IDMapOwnPointer> install_callbacks_;
IDMap<FetchCallback, IDMapOwnPointer> fetch_callbacks_;

Powered by Google App Engine
This is Rietveld 408576698