Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: content/browser/devtools/embedded_worker_devtools_manager.cc

Issue 761923004: Keep alive ServiceWorkers when devtools is attached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ASSERT_TRUE -> DCHECK :( Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/embedded_worker_devtools_manager.cc
diff --git a/content/browser/devtools/embedded_worker_devtools_manager.cc b/content/browser/devtools/embedded_worker_devtools_manager.cc
index 1e36e76c3bcec78db281b934070137eaedca3aca..aad356cdecc7087aea587535550c6e32623e7b77 100644
--- a/content/browser/devtools/embedded_worker_devtools_manager.cc
+++ b/content/browser/devtools/embedded_worker_devtools_manager.cc
@@ -139,6 +139,13 @@ void EmbeddedWorkerDevToolsManager::WorkerDestroyed(int worker_process_id,
DevToolsManager::GetInstance()->AgentHostChanged(agent_host);
}
+void EmbeddedWorkerDevToolsManager::WorkerStopIgnored(int worker_process_id,
+ int worker_route_id) {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ // TODO(pfeldman): Show a console message to tell the user that UA didn't
+ // terminate the worker because devtools is attached.
+}
+
void EmbeddedWorkerDevToolsManager::WorkerReadyForInspection(
int worker_process_id,
int worker_route_id) {
« no previous file with comments | « content/browser/devtools/embedded_worker_devtools_manager.h ('k') | content/browser/service_worker/embedded_worker_instance.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698