Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: content/browser/devtools/embedded_worker_devtools_agent_host.cc

Issue 761923004: Keep alive ServiceWorkers when devtools is attached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ASSERT_TRUE -> DCHECK :( Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/embedded_worker_devtools_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/embedded_worker_devtools_agent_host.cc
diff --git a/content/browser/devtools/embedded_worker_devtools_agent_host.cc b/content/browser/devtools/embedded_worker_devtools_agent_host.cc
index 8da53a8656405505c7924ee700e7b23485a504ee..955f04fa7e0205d59e1f4ed4b83b6cae1aea416e 100644
--- a/content/browser/devtools/embedded_worker_devtools_agent_host.cc
+++ b/content/browser/devtools/embedded_worker_devtools_agent_host.cc
@@ -35,8 +35,18 @@ void TerminateServiceWorkerOnIO(
}
}
+void SetDevToolsAttachedOnIO(
+ base::WeakPtr<ServiceWorkerContextCore> context_weak,
+ int64 version_id,
+ bool attached) {
+ if (ServiceWorkerContextCore* context = context_weak.get()) {
+ if (ServiceWorkerVersion* version = context->GetLiveVersion(version_id))
+ version->SetDevToolsAttached(attached);
+ }
}
+} // namespace
+
EmbeddedWorkerDevToolsAgentHost::EmbeddedWorkerDevToolsAgentHost(
WorkerId worker_id,
const SharedWorkerInstance& shared_worker)
@@ -125,6 +135,13 @@ void EmbeddedWorkerDevToolsAgentHost::Attach() {
void EmbeddedWorkerDevToolsAgentHost::OnClientAttached() {
DevToolsAgentHostImpl::NotifyCallbacks(this, true);
+ if (service_worker_) {
+ BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
+ base::Bind(&SetDevToolsAttachedOnIO,
+ service_worker_->context_weak(),
+ service_worker_->version_id(),
+ true));
+ }
}
void EmbeddedWorkerDevToolsAgentHost::OnClientDetached() {
@@ -135,6 +152,13 @@ void EmbeddedWorkerDevToolsAgentHost::OnClientDetached() {
state_ = WORKER_UNINSPECTED;
}
DevToolsAgentHostImpl::NotifyCallbacks(this, false);
+ if (service_worker_) {
+ BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
+ base::Bind(&SetDevToolsAttachedOnIO,
+ service_worker_->context_weak(),
+ service_worker_->version_id(),
+ false));
+ }
}
bool EmbeddedWorkerDevToolsAgentHost::OnMessageReceived(
« no previous file with comments | « no previous file | content/browser/devtools/embedded_worker_devtools_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698