Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 761913002: Ship harmony-strings (Closed)

Created:
6 years ago by Dmitry Lomov (no reviews)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Ship harmony-strings R=rossberg@chromium.org, yangguo@chromium.org LOG=Y

Patch Set 1 #

Patch Set 2 : webkit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -31 lines) Patch
M BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +3 lines, -3 lines 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt View 1 2 chunks +5 lines, -24 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Dmitry Lomov (no reviews)
PTAL
6 years ago (2014-11-27 08:29:24 UTC) #1
Yang
On 2014/11/27 08:29:24, Dmitry Lomov (chromium) wrote: > PTAL lgtm.
6 years ago (2014-11-27 08:38:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761913002/20001
6 years ago (2014-11-27 09:49:14 UTC) #4
aandrey
does it need devtools support? i suppose at least syntax highlighting should be changed?
6 years ago (2014-11-27 10:08:28 UTC) #6
aandrey
nevermind, I confused it with template strings.
6 years ago (2014-11-27 10:09:52 UTC) #7
commit-bot: I haz the power
6 years ago (2014-11-27 10:17:11 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698