testing/android/junit/javatests/src/org/chromium/testing/local/GtestLoggerTest.java - Issue 761903003: Update from https://crrev.com/306655

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/android/junit/javatests/src/org/chromium/testing/local/GtestLoggerTest.java

Issue 761903003: Update from https://crrev.com/306655 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « testing/android/junit/javatests/src/org/chromium/testing/local/GtestFilterTest.java ('k') | testing/android/junit/javatests/src/org/chromium/testing/local/RunnerFilterTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: testing/android/junit/javatests/src/org/chromium/testing/local/GtestLoggerTest.java

diff --git a/testing/android/junit/javatests/src/org/chromium/testing/local/GtestLoggerTest.java b/testing/android/junit/javatests/src/org/chromium/testing/local/GtestLoggerTest.java

index 2bb30405cafcb53b343b8989cb22c3f16cf3916e..0520901bcf315a3fdaf5300d9ac59c30081df64c 100644

--- a/testing/android/junit/javatests/src/org/chromium/testing/local/GtestLoggerTest.java

+++ b/testing/android/junit/javatests/src/org/chromium/testing/local/GtestLoggerTest.java

@@ -114,9 +114,9 @@ public class GtestLoggerTest {

Set<Description> failures = new TreeSet<Description>(new DescriptionComparator());

failures.add(Description.createTestDescription(

- "GtestLoggerTest", "testTestRunFinishedNoFailures"));

+ GtestLoggerTest.class, "testTestRunFinishedNoFailures"));

failures.add(Description.createTestDescription(

- "GtestLoggerTest", "testTestRunFinishedWithFailures"));

+ GtestLoggerTest.class, "testTestRunFinishedWithFailures"));

loggerUnderTest.testRunFinished(1232, failures, 4312);

Assert.assertEquals(

@@ -124,8 +124,10 @@ public class GtestLoggerTest {

+ "[==========] 1234 tests ran. (4312 ms total)\n"

+ "[ PASSED ] 1232 tests.\n"

+ "[ FAILED ] 2 tests.\n"

- + "[ FAILED ] GtestLoggerTest.testTestRunFinishedNoFailures\n"

- + "[ FAILED ] GtestLoggerTest.testTestRunFinishedWithFailures\n"

+ + "[ FAILED ] org.chromium.testing.local.GtestLoggerTest"

+ + ".testTestRunFinishedNoFailures\n"

+ + "[ FAILED ] org.chromium.testing.local.GtestLoggerTest"

+ + ".testTestRunFinishedWithFailures\n"

+ "\n",

actual.toString());

}