Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 761903003: Update from https://crrev.com/306655 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index dec594bace509fa92307fb3482b5b04ca16f56cd..422168c009c05eab4fe90324fcff8db73d19b799 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -542,7 +542,8 @@ bool GLES2Decoder::GetServiceTextureId(uint32 client_texture_id,
GLES2Decoder::GLES2Decoder()
: initialized_(false),
debug_(false),
- log_commands_(false) {
+ log_commands_(false),
+ unsafe_es3_apis_enabled_(false) {
}
GLES2Decoder::~GLES2Decoder() {
@@ -629,7 +630,13 @@ class GLES2DecoderImpl : public GLES2Decoder,
return vertex_array_manager_.get();
}
ImageManager* GetImageManager() override { return image_manager_.get(); }
+
+ ValuebufferManager* GetValuebufferManager() override {
+ return valuebuffer_manager();
+ }
+
bool ProcessPendingQueries(bool did_finish) override;
+
bool HasMoreIdleWork() override;
void PerformIdleWork() override;
@@ -1366,6 +1373,11 @@ class GLES2DecoderImpl : public GLES2Decoder,
GLenum target, GLenum attachment, GLenum textarget,
GLuint texture, GLint level, GLsizei samples);
+ // Wrapper for glFramebufferTextureLayer.
+ void DoFramebufferTextureLayer(
+ GLenum target, GLenum attachment, GLuint texture, GLint level,
+ GLint layer);
+
// Wrapper for glGenerateMipmap
void DoGenerateMipmap(GLenum target);
@@ -2427,10 +2439,14 @@ bool GLES2DecoderImpl::Initialize(
set_log_commands(true);
}
+ if (CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableUnsafeES3APIs)) {
+ set_unsafe_es3_apis_enabled(true);
+ }
+
compile_shader_always_succeeds_ = CommandLine::ForCurrentProcess()->HasSwitch(
switches::kCompileShaderAlwaysSucceeds);
-
// Take ownership of the context and surface. The surface can be replaced with
// SetSurface.
context_ = context;
@@ -2839,6 +2855,7 @@ Capabilities GLES2DecoderImpl::GetCapabilities() {
feature_info_->feature_flags().blend_equation_advanced;
caps.blend_equation_advanced_coherent =
feature_info_->feature_flags().blend_equation_advanced_coherent;
+ caps.texture_rg = feature_info_->feature_flags().ext_texture_rg;
return caps;
}
@@ -5364,6 +5381,25 @@ void GLES2DecoderImpl::DoFramebufferTexture2DCommon(
OnFboChanged();
}
+void GLES2DecoderImpl::DoFramebufferTextureLayer(
+ GLenum target, GLenum attachment, GLuint client_texture_id,
+ GLint level, GLint layer) {
+ // TODO(zmo): Unsafe ES3 API, missing states update.
+ GLuint service_id = 0;
+ TextureRef* texture_ref = NULL;
+ if (client_texture_id) {
+ texture_ref = GetTexture(client_texture_id);
+ if (!texture_ref) {
+ LOCAL_SET_GL_ERROR(
+ GL_INVALID_OPERATION,
+ "glFramebufferTextureLayer", "unknown texture_ref");
+ return;
+ }
+ service_id = texture_ref->service_id();
+ }
+ glFramebufferTextureLayer(target, attachment, service_id, level, layer);
+}
+
void GLES2DecoderImpl::DoGetFramebufferAttachmentParameteriv(
GLenum target, GLenum attachment, GLenum pname, GLint* params) {
Framebuffer* framebuffer = GetFramebufferInfoForTarget(target);
@@ -7415,6 +7451,24 @@ void GLES2DecoderImpl::DoVertexAttrib4fv(GLuint index, const GLfloat* v) {
}
}
+error::Error GLES2DecoderImpl::HandleVertexAttribIPointer(
+ uint32 immediate_data_size,
+ const void* cmd_data) {
+ // TODO(zmo): Unsafe ES3 API, missing states update.
+ if (!unsafe_es3_apis_enabled())
+ return error::kUnknownCommand;
+ const gles2::cmds::VertexAttribIPointer& c =
+ *static_cast<const gles2::cmds::VertexAttribIPointer*>(cmd_data);
+ GLuint indx = c.indx;
+ GLint size = c.size;
+ GLenum type = c.type;
+ GLsizei stride = c.stride;
+ GLsizei offset = c.offset;
+ const void* ptr = reinterpret_cast<const void*>(offset);
+ glVertexAttribIPointer(indx, size, type, stride, ptr);
+ return error::kNoError;
+}
+
error::Error GLES2DecoderImpl::HandleVertexAttribPointer(
uint32 immediate_data_size,
const void* cmd_data) {
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder_autogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698